From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: warn on tree blocks which are not nodesize aligned
Date: Wed, 6 Sep 2023 17:34:15 +0800 [thread overview]
Message-ID: <bb023679-f804-97a6-601b-56a161ef5a0e@oracle.com> (raw)
In-Reply-To: <09481f8720302e0c4aaee7e460c142f632c72fe8.1692858397.git.wqu@suse.com>
On 8/24/23 14:33, Qu Wenruo wrote:
> A long time ago, we have some metadata chunks which starts at sector
> boundary but not aligned at nodesize boundary.
>
> + if (!IS_ALIGNED(start, fs_info->nodesize) &&
> + !test_and_set_bit(BTRFS_FS_UNALIGNED_TREE_BLOCK,
> + &fs_info->flags)) {
> + btrfs_warn(fs_info,
> + "tree block not nodesize aligned, start %llu nodesize %u",
> + start, fs_info->nodesize);
> + btrfs_warn(fs_info, "this can be solved by a full metadata balance");
> + }
> return 0;
I don't know if ratelimited is required here. But, that shouldn't be a
no-go for the patch.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thanks.
next prev parent reply other threads:[~2023-09-06 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 6:33 [PATCH 0/3] btrfs: make extent buffer memory continuous Qu Wenruo
2023-08-24 6:33 ` [PATCH 1/3] btrfs: warn on tree blocks which are not nodesize aligned Qu Wenruo
2023-09-06 9:34 ` Anand Jain [this message]
2023-09-06 16:53 ` David Sterba
2023-08-24 6:33 ` [PATCH 2/3] btrfs: map uncontinuous extent buffer pages into virtual address space Qu Wenruo
2023-08-28 10:36 ` Johannes Thumshirn
2023-08-24 6:33 ` [PATCH 3/3] btrfs: utilize the physically/virtually continuous extent buffer memory Qu Wenruo
2023-09-06 2:45 ` kernel test robot
2023-09-06 17:49 ` [PATCH 0/3] btrfs: make extent buffer memory continuous David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb023679-f804-97a6-601b-56a161ef5a0e@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).