Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Askar Safin <safinaskar@gmail.com>, wqu@suse.com
Cc: linux-btrfs@vger.kernel.org,
	Chris Murphy <lists@colorremedies.com>,
	David Sterba <dsterba@suse.com>
Subject: Re: [PATCH RFC] btrfs: exit scrub and balance early if the fs is being frozen
Date: Mon, 13 Oct 2025 10:26:18 +1030	[thread overview]
Message-ID: <bb658f9d-510a-4265-944e-88b2ba83d134@gmx.com> (raw)
In-Reply-To: <20251012082355.5226-1-safinaskar@gmail.com>



在 2025/10/12 18:53, Askar Safin 写道:
> Qu Wenruo <wqu@suse.com>:
>> There are some reports that btrfs is unable to be frozen if there is a
> 
> I tested your patch on real hardware.
> 
> I applied it to current Linux mainline.
> 
> I have btrfs-raid on two big disks.
> 
> I started "sudo btrfs scrub start -B -d /" and pressed "Suspend" in GUI.
> 
> If /sys/power/freeze_filesystems is 0 (this is default), then your patch doesn't work.
> 
> If /sys/power/freeze_filesystems is 1, then the system stops to respond for a minute
> and then suspends. Here is journalctl:
> https://zerobin.net/?e3376d7d056dcb04#LyzGFYeVdWsbZfgC25G4TuSct6QDyZ278gQlZgCfR94= .
> 
> As well as I understand from journalctl, systemd tries to freeze userspace
> process "btrfs scrub" and fails. Then systemd times out after a minute,
> and then suspend proceeds.
> 
> So, in short, this is not complete solution yet.
> 
> Also I tested Sterba's patch, and it doesn't work either:
> https://lore.kernel.org/linux-btrfs/20250720194803.3661-1-safinaskar@zohomail.com/ .
> 
> I really want this bug to be fixed. Please, CC me with your future attempts.

I'll send you new experimental patch(es) first for test.

In fact I already have some idea how to address it, but unfortunately it 
may take some time.

And it will address scrub first, then addressing balance related operations.

Thanks,
Qu
> 


  reply	other threads:[~2025-10-12 23:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07  0:25 [PATCH RFC] btrfs: exit scrub and balance early if the fs is being frozen Qu Wenruo
2025-07-07  5:23 ` Qu Wenruo
2025-07-07 12:30   ` David Sterba
2025-07-07 12:37     ` Daniel Vacek
2025-07-07 22:16     ` Qu Wenruo
2025-07-07 12:25 ` David Sterba
2025-10-12  8:23 ` Askar Safin
2025-10-12 23:56   ` Qu Wenruo [this message]
2025-10-15  4:05     ` Askar Safin
2025-10-15  7:00   ` Qu Wenruo
2025-10-15  7:59     ` Askar Safin
2025-10-15  8:07       ` Qu Wenruo
2025-10-15 11:12     ` Askar Safin
2025-10-15 23:01       ` Qu Wenruo
2025-10-16  8:40         ` Askar Safin
2025-10-16  9:46           ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb658f9d-510a-4265-944e-88b2ba83d134@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    --cc=safinaskar@gmail.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox