From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB66C433EF for ; Mon, 16 May 2022 17:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344378AbiEPRmb (ORCPT ); Mon, 16 May 2022 13:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240306AbiEPRma (ORCPT ); Mon, 16 May 2022 13:42:30 -0400 Received: from smtp.smtpout.orange.fr (smtp06.smtpout.orange.fr [80.12.242.128]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E2A0377D5 for ; Mon, 16 May 2022 10:42:27 -0700 (PDT) Received: from [192.168.1.18] ([86.243.180.246]) by smtp.orange.fr with ESMTPA id qejfnDLFJpmc6qejfntg18; Mon, 16 May 2022 19:42:25 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Mon, 16 May 2022 19:42:25 +0200 X-ME-IP: 86.243.180.246 Message-ID: Date: Mon, 16 May 2022 19:42:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] btrfs: Fix an error handling path in btrfs_read_sys_array() Content-Language: en-US To: dsterba@suse.cz, Dan Carpenter , Qu Wenruo , Chris Mason , Josef Bacik , David Sterba , Qu Wenruo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org References: <120e4c34-da48-7d86-4a50-c31a3804600d@gmx.com> <20220516135407.GM4009@kadam> <20220516150148.GX18596@twin.jikos.cz> From: Christophe JAILLET In-Reply-To: <20220516150148.GX18596@twin.jikos.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org Le 16/05/2022 à 17:01, David Sterba a écrit : > On Mon, May 16, 2022 at 04:54:07PM +0300, Dan Carpenter wrote: >> On Sun, May 15, 2022 at 06:57:25AM +0800, Qu Wenruo wrote: >>> >>> >>> On 2022/5/14 20:01, Christophe JAILLET wrote: >>>> If alloc_dummy_extent_buffer() we should return an error code, not 0 that >>>> would mean success. >>>> >>>> Fixes: a1fc41ac28d3 ("btrfs: use dummy extent buffer for super block sys chunk array read") >>>> Signed-off-by: Christophe JAILLET >>> >>> Reviewed-by: Qu Wenruo >>> >>> All my fault, thanks for catching it. >>> Qu >>> >> >> I sent this patch in January and David was going to fold it into the >> original patch but it got lost. Thanks, Christophe! Hi, Not exactly. Your patch was: - if (IS_ERR(sb)) - return PTR_ERR(sb); + if (!sb) + return -ENOMEM; Mine is only: - return PTR_ERR(sb); + return -ENOMEM; So for some reason, what you had reported was just half applied. (or half fixed by someone else) > > I found my reply to your fix that I folded the fixup, but then it got > lost for some reason. Probably because I picked the patchset from > mailing list again and did not take the local branch. I'll fold the fix > again as it' still in the unmerged branch. Thanks. > just in case, the Fixes tag in Dan's patch leads to: "Notice: this object is not reachable from any branch." I don't think that it is of any importance if the fix in folded, but in case, I let you know. CJ