From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED99EC6FA8A for ; Sat, 10 Sep 2022 11:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbiIJLeI (ORCPT ); Sat, 10 Sep 2022 07:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbiIJLeG (ORCPT ); Sat, 10 Sep 2022 07:34:06 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C97615302B for ; Sat, 10 Sep 2022 04:34:05 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id y3so9903497ejc.1 for ; Sat, 10 Sep 2022 04:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=8Ag6mHz6RaJKAvIf3yWG8/NFxf6UdfL+MIDBEsLCyN8=; b=rt56lu4zDxtfFC0gCwopFBFWhVClMEv05ZLa6FVTJvWQfkY2PRelXahCVRkTH0W0EE SDi7Jg1T1Uk7Cgx8nOrb1llp4a5ljwV0hdWJLnKvHp44g8AGFKUUuXIYEu47fVHTnc+/ 8wGHkEV4bRaaeVojMOyW1sd84KJqpHyhoHmwKscMTML1EIFROO1ffCslzJIrMkPlYesA CBTvyvCmvmcJsItPrNfbGgD6LX3xXNlU+Uvr8Wo01rpF/CTHcxytcMd7P56VsFix0FeR nYU0jAzsSdPZvhNnm7dXkuhgwaXZBEfS/U1FJvc3Zvz9IP4l/XZZ4aGZLlBa7gaLGUT8 q2nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8Ag6mHz6RaJKAvIf3yWG8/NFxf6UdfL+MIDBEsLCyN8=; b=YWuQute+e0aT/YGqwMKiD4rF+Asx7LZeqkkdu41xh/DK0tWmutOmJCibu4Zp09tJq6 C0LLp3ChuiOlxiKVThSKUypNFr42EWf4KFFUCEqI+EsiSl9fyAroCaZFNIPjdkdd0RBx bsKIUL+3A/BSlSvcOid1TWoXnVbGFeOMrOOCJ+lcvvxQ/QQBI5tSEZ9M19sTvVr6rj0F fxgFoaOkEHKwwHX7ccAe+5zSGa5eDx5gRNekVKrgPaQDb/dcIR4gXaKpF3AkPmBhR9/g I0dv9mdXX5Y0J6zPiIorsMZaaXKO9WsJo5w17KgDbkEcYaptr6LPPpfgW3hnf82V5Dr6 vKIA== X-Gm-Message-State: ACgBeo1KKVj7GocoCIWUA1XNjx0qFmYza9R8uJYKljE30edsNf4i+YFE TuQ81tFbG3Ise06OShsFf+SRKA== X-Google-Smtp-Source: AA6agR6l/1o9KPVR6GtRSUN/6LhKnQUVR80O3xKSuOcDWQt5wKNsZnh3qcOtdZWGGeWimCE3wtzgXg== X-Received: by 2002:a17:906:9750:b0:77b:6f08:986f with SMTP id o16-20020a170906975000b0077b6f08986fmr1210041ejy.416.1662809644338; Sat, 10 Sep 2022 04:34:04 -0700 (PDT) Received: from [10.41.110.194] ([77.241.232.19]) by smtp.gmail.com with ESMTPSA id s1-20020a056402014100b0044e8d0682b2sm2014194edu.71.2022.09.10.04.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Sep 2022 04:34:03 -0700 (PDT) Message-ID: Date: Sat, 10 Sep 2022 05:34:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton Cc: Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-2-hch@lst.de> From: Jens Axboe In-Reply-To: <20220910065058.3303831-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 9/10/22 12:50 AM, Christoph Hellwig wrote: > @@ -2390,8 +2392,13 @@ static int filemap_read_folio(struct file *file, filler_t filler, > * fails. > */ > folio_clear_error(folio); > + > /* Start the actual read. The read will unlock the page. */ > + if (unlikely(workingset)) > + psi_memstall_enter(&pflags); > error = filler(file, folio); > + if (unlikely(workingset)) > + psi_memstall_leave(&pflags); > if (error) > return error; I think this would read better as: /* Start the actual read. The read will unlock the page. */ if (unlikely(workingset)) { psi_memstall_enter(&pflags); error = filler(file, folio); psi_memstall_leave(&pflags); } else { error = filler(file, folio); } if (error) return error; -- Jens Axboe