Re: fixes for handling of split direct I/O bios

Sweet Tea Dorminy
2022-03-24T16:49:30Z

On 3/24/22 12:06, Christoph Hellwig wrote:
> Hi all,
>
> this series fixes two problems in the direct I/O code where the
> file_offset field in the dio_private structure is used in a context where
> we really need the file_offset for the given low-level bios and not for
> the bio submitted by the iomap direct I/O as recorded in the dio_private
> structure. To do so we need a new file_offset in the btrfs_dio
> structure.
>
> Found by code inspection as part of my bio cleanups.
>
> Diffstat:
> extent_io.c | 1 +
> inode.c | 18 ++++++++----------
> volumes.h | 3 +++
> 3 files changed, 12 insertions(+), 10 deletions(-)

Reviewed-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>

I'm pretty new and don't know much about the criteria for cc'ing stable,
but arguably this makes the check_data_csum() error message not lie
about the start offset in such cases and it seems like a very low risk
improvement to me... might it be worth adding a Fixes: tag / might this
be a reasonable fix for stable?