From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: submit_read_repair() cleanup
Date: Wed, 13 Apr 2022 16:46:38 +0300 [thread overview]
Message-ID: <bd0049df-d5e6-9157-41c4-fa31c3c97fca@suse.com> (raw)
In-Reply-To: <9e29ec4e546249018679224518a465d0240912b0.1647841657.git.wqu@suse.com>
On 21.03.22 г. 7:48 ч., Qu Wenruo wrote:
> Cleanup the function submit_read_repair() by:
>
> - Remove the fixed argument submit_bio_hook()
> The function is only called on buffered data read path, so the
> @submit_bio_hook argument is always btrfs_submit_data_bio().
>
> Since it's fixed, then there is no need to pass that argument at all.
>
> - Rename the function to submit_data_read_repair()
> Just to be more explicit on all the 3 things, data, read and repair.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
prev parent reply other threads:[~2022-04-13 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 5:48 [PATCH] btrfs: submit_read_repair() cleanup Qu Wenruo
2022-04-11 17:06 ` David Sterba
2022-04-13 13:46 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd0049df-d5e6-9157-41c4-fa31c3c97fca@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox