From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669B4C43331 for ; Wed, 1 Apr 2020 10:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 097AF2078B for ; Wed, 1 Apr 2020 10:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732169AbgDAK6P (ORCPT ); Wed, 1 Apr 2020 06:58:15 -0400 Received: from zaphod.cobb.me.uk ([213.138.97.131]:34272 "EHLO zaphod.cobb.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732147AbgDAK6P (ORCPT ); Wed, 1 Apr 2020 06:58:15 -0400 Received: by zaphod.cobb.me.uk (Postfix, from userid 107) id 84ABA9C41D; Wed, 1 Apr 2020 11:58:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cobb.uk.net; s=201703; t=1585738693; bh=hjgpzpZ8wnvTW1+KQ9y52Yg/l/HjrFg2D3oO0y88QHE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cfBQa77qiZHBHsbD6GqXh3tTaCoNMeGvoudOtIInP2dHL65PTElZqMESyIviJmGOU p4UeWUpcQ3e218UiUOEf07MTh2BOmx0Kqx0MOUM+PKGwRQgcjEB1K8uY50sw2eUa9T oiSzw81EqGIVPrfWJpb9Vdxr/idowreD9/QrkXLVRXv0DzPelqzfU6k6iCvhFJ6+Bj C+z+p3FFYjNEp2KFvnB/srPlTdRLxkoyB9Ovf2r1otqjdNbUd7X8h0NxOnxCxRuawM FPJwAyUZ1eOPyo30lpmQDkoyoS/JxVVLsGz+JVzZXUirTT9qJFDOP0rmd8GRBYw5gq nV2FV1sKUkPbg== Received: from black.home.cobb.me.uk (unknown [192.168.0.205]) by zaphod.cobb.me.uk (Postfix) with ESMTP id 97C5A9B92E; Wed, 1 Apr 2020 11:58:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cobb.uk.net; s=201703; t=1585738684; bh=hjgpzpZ8wnvTW1+KQ9y52Yg/l/HjrFg2D3oO0y88QHE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MwCBnAaKKim42V6AeRRC/nuFDxu7JxrazyyFVs0QtF1mvrwLoR3HqYqyJuy8EtSyu nrcl0NRMCRQdEffjjuIx5Zq8tCYTYWob10Ps21u3QZurzchBeCMDZs+Js5MSsH8if+ G5WozOm3GTIOR2CyWJQYVB3iM7YtnNoxQPjD5A1p2lbOK9ddaFmqKFELHa7/ppYTl5 KnNpD6vySyHZLBs1KYzbAUwAbjixJd/+947jrrqHbOUiV5FhFtbs4yvaYK63j6YGb0 68IDfHrFNjzC0ayWUez0ObVjHSLWeAZYxxiF5Vbl9QJ8pcRdVwvZ03xqyGq2pq2pVH KjyxxiJPcmTZA== Received: from [192.168.0.211] (novatech.home.cobb.me.uk [192.168.0.211]) by black.home.cobb.me.uk (Postfix) with ESMTPS id 029E0DC9CD; Wed, 1 Apr 2020 11:58:03 +0100 (BST) Subject: Re: [PATCH v2] btrfs-progs: add warning for mixed profiles filesystem To: Zygo Blaxell Cc: Goffredo Baroncelli , linux-btrfs@vger.kernel.org, Qu Wenruo , David Sterba References: <20200331191045.8991-1-kreijack@libero.it> <97ec9f13-8d8d-1df9-f725-44a2a0ecc438@cobb.uk.net> <20200331220534.GI2693@hungrycats.org> From: Graham Cobb Openpgp: preference=signencrypt Autocrypt: addr=g.btrfs@cobb.uk.net; prefer-encrypt=mutual; keydata= mQINBFaetnIBEAC5cHHbXztbmZhxDof6rYh/Dd5otxJXZ1p7cjE2GN9hCH7gQDOq5EJNqF9c VtD9rIywYT1i3qpHWyWo0BIwkWvr1TyFd3CioBe7qfo/8QoeA9nnXVZL2gcorI85a2GVRepb kbE22X059P1Z1Cy7c29dc8uDEzAucCILyfrNdZ/9jOTDN9wyyHo4GgPnf9lW3bKqF+t//TSh SOOis2+xt60y2In/ls29tD3G2ANcyoKF98JYsTypKJJiX07rK3yKTQbfqvKlc1CPWOuXE2x8 DdI3wiWlKKeOswdA2JFHJnkRjfrX9AKQm9Nk5JcX47rLxnWMEwlBJbu5NKIW5CUs/5UYqs5s 0c6UZ3lVwinFVDPC/RO8ixVwDBa+HspoSDz1nJyaRvTv6FBQeiMISeF/iRKnjSJGlx3AzyET ZP8bbLnSOiUbXP8q69i2epnhuap7jCcO38HA6qr+GSc7rpl042mZw2k0bojfv6o0DBsS/AWC DPFExfDI63On6lUKgf6E9vD3hvr+y7FfWdYWxauonYI8/i86KdWB8yaYMTNWM/+FAKfbKRCP dMOMnw7bTbUJMxN51GknnutQlB3aDTz4ze/OUAsAOvXEdlDYAj6JqFNdZW3k9v/QuQifTslR JkqVal4+I1SUxj8OJwQWOv/cAjCKJLr5g6UfUIH6rKVAWjEx+wARAQABtDNHcmFoYW0gQ29i YiAoUGVyc29uYWwgYWRkcmVzcykgPGdyYWhhbUBjb2JiLnVrLm5ldD6JAlEEEwECADsCGwEG CwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAhkBBQJWnr9UFRhoa3A6Ly9rZXlzLmdudXBnLm5l dAAKCRBv35GGXfm3Tte8D/45+/dnVdvzPsKgnrdoXpmvhImGaSctn9bhAKvng7EkrQjgV3cf C9GMgK0vEJu+4f/sqWA7hPKUq/jW5vRETcvqEp7v7z+56kqq5LUQE5+slsEb/A4lMP4ppwd+ TPwwDrtVlKNqbKJOM0kPkpj7GRy3xeOYh9D7DtFj2vlmaAy6XvKav/UUU4PoUdeCRyZCRfl0 Wi8pQBh0ngQWfW/VqI7VsG3Qov5Xt7cTzLuP/PhvzM2c5ltZzEzvz7S/jbB1+pnV9P7WLMYd EjhCYzJweCgXyQHCaAWGiHvBOpmxjbHXwX/6xTOJA5CGecDeIDjiK3le7ubFwQAfCgnmnzEj pDG+3wq7co7SbtGLVM3hBsYs27M04Oi2aIDUN1RSb0vsB6c07ECT52cggIZSOCvntl6n+uMl p0WDrl1i0mJUbztQtDzGxM7nw+4pJPV4iX1jJYbWutBwvC+7F1n2F6Niu/Y3ew9a3ixV2+T6 aHWkw7/VQvXGnLHfcFbIbzNoAvI6RNnuEqoCnZHxplEr7LuxLR41Z/XAuCkvK41N/SOI9zzT GLgUyQVOksdbPaxTgBfah9QlC9eXOKYdw826rGXQsvG7h67nqi67bp1I5dMgbM/+2quY9xk0 hkWSBKFP7bXYu4kjXZUaYsoRFEfL0gB53eF21777/rR87dEhptCnaoXeqbkBDQRWnrnDAQgA 0fRG36Ul3Y+iFs82JPBHDpFJjS/wDK+1j7WIoy0nYAiciAtfpXB6hV+fWurdjmXM4Jr8x73S xHzmf9yhZSTn3nc5GaK/jjwy3eUdoXu9jQnBIIY68VbgGaPdtD600QtfWt2zf2JC+3CMIwQ2 fK6joG43sM1nXiaBBHrr0IadSlas1zbinfMGVYAd3efUxlIUPpUK+B1JA12ZCD2PCTdTmVDe DPEsYZKuwC8KJt60MjK9zITqKsf21StwFe9Ak1lqX2DmJI4F12FQvS/E3UGdrAFAj+3HGibR yfzoT+w9UN2tHm/txFlPuhGU/LosXYCxisgNnF/R4zqkTC1/ao7/PQARAQABiQIlBBgBAgAP BQJWnrnDAhsMBQkJZgGAAAoJEG/fkYZd+bdO9b4P/0y3ADmZkbtme4+Bdp68uisDzfI4c/qo XSLTxY122QRVNXxn51yRRTzykHtv7/Zd/dUD5zvwj2xXBt9wk4V060wtqh3lD6DE5mQkCVar eAfHoygGMG+/mJDUIZD56m5aXN5Xiq77SwTeqJnzc/lYAyZXnTAWfAecVSdLQcKH21p/0AxW GU9+IpIjt8XUEGThPNsCOcdemC5u0I1ZeVRXAysBj2ymH0L3EW9B6a0airCmJ3Yctm0maqy+ 2MQ0Q6Jw8DWXbwynmnmzLlLEaN8wwAPo5cb3vcNM3BTcWMaEUHRlg82VR2O+RYpbXAuPOkNo 6K8mxta3BoZt3zYGwtqc/cpVIHpky+e38/5yEXxzBNn8Rn1xD6pHszYylRP4PfolcgMgi0Ny 72g40029WqQ6B7bogswoiJ0h3XTX7ipMtuVIVlf+K7r6ca/pX2R9B/fWNSFqaP4v0qBpyJdJ LO/FP87yHpEDbbKQKW6Guf6/TKJ7iaG3DDpE7CNCNLfFG/skhrh5Ut4zrG9SjA+0oDkfZ4dI B8+QpH3mP9PxkydnxGiGQxvLxI5Q+vQa+1qA5TcCM9SlVLVGelR2+Wj2In+t2GgigTV3PJS4 tMlN++mrgpjfq4DMYv1AzIBi6/bSR6QGKPYYOOjbk+8Sfao0fmjQeOhj1tAHZuI4hoQbowR+ myxb Message-ID: Date: Wed, 1 Apr 2020 11:58:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200331220534.GI2693@hungrycats.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 31/03/2020 23:05, Zygo Blaxell wrote: > On Tue, Mar 31, 2020 at 10:46:17PM +0100, Graham Cobb wrote: >> On 31/03/2020 20:10, Goffredo Baroncelli wrote: >>> WARNING: ------------------------------------------------------ >>> WARNING: Detection of multiple profiles for a block group type: >>> WARNING: >>> WARNING: * DATA -> [raid1c3, single] >>> WARNING: * METADATA -> [raid1, single] >>> WARNING: >>> WARNING: Please consider using 'btrfs balance ...' commands set >>> WARNING: to solve this issue. >>> WARNING: ------------------------------------------------------ >> ... >> I would suggest a more compact layout and factual tone. Something like: >> >> Caution: This filesystem has multiple profiles for a block group type >> so new block groups will have unpredictable profiles. >> * DATA -> [raid1c3, single] >> * METADATA -> [raid1, single] >> Use of 'btrfs balance' is recommended as soon as possible to move all >> blocks to a single profile for each of data and metadata. > > How about a one-liner: > > NOTE: Multiple profiles detected. See 'man btrfs-filesystem'. > > with a section in the btrfs-filesystem man page giving a detailed > description of the problem and examples of possible remedies. > Even better. I have just realised that the information in the "* DATA -> [raid1c3, single]" part of the message is, of course, available in the rest of the output so doesn't need to be included. I would suggest including a very brief description of the problem, in order to prompt people to actually take action. How about: Caution: Multiple profiles detected which will cause unpredictable profiles for new data. See 'man btrfs-filesystem' for recommendations.