Re: [PATCH 0/7] btrfs: fix periodic reclaim condition with some cleanup

[Sun Yangkai <sunk67188@gmail.com>]

在 2026/1/2 05:14, Qu Wenruo 写道:
> 
> 
> 在 2026/1/1 22:24, Sun Yangkai 写道:
>>
>>
>> 在 2026/1/1 08:13, Qu Wenruo 写道:
>>>
>>>
>>> 在 2025/12/31 21:09, Sun YangKai 写道:
>>>> This series eliminates wasteful periodic reclaim operations that were occurring
>>>> when already failed to reclaim any new space, and includes several preparatory
>>>> cleanups.
>>>>
>>>> Patch 1-6 are non-functional changes.
>>>>
>>>> Patch 7 fixes the core issue, details are in the commit message.
>>>
>>> Fix first then cleanup please, this will make backport much easier.
>>>
>>> Thanks,
>>> Qu
>>
>> Sorry for bothering. I have no experience with backport things so I need some
>> more guidance here.
>>
>> The fix patch needs two of the cleanup patches applied.
> 
> I didn't see anything in the cleanup that are significantly changing the behavior.
> 
> Maybe some minor structure member or type change, but that's all.
> 
> Your fix should still work use the older types/members, and that will make
> backport much easier, without the need to backport the cleanup as dependency.
> 
>> I currently have no idea
>> what I could do to make backport easier. Should I also add "Fixes:" tag to the
>> two cleanup patch?
> 
> Definitely no, and those cleanup should only be done after a fix.
> 
> Cleanup is not a fix, thus they should not have such fixes tags.
> 
>> Or should I squash the two cleanup and one fix together to
>> make a patch just for backport?
> 
> No either.
> 
> I did a quick simple reorder, and only minor changes needed to pass compile (not
> tested). The reordered fix is attached.

I've seen the patch. It will not work correctly but I've got the idea. I'll move
the fix patch in v2 patch set.

> Keep in mind that, during development you should focus on the fix first,
> ignoring all the unrelated minor problems, which should make your fix small and
> that's making it easier to backport.

Got it.

Thanks a lot :)
Sun YangKai