Re: [PATCH 2/6] btrfs: qgroup: abort transaction on failure to add qgroup relation

[Qu Wenruo <wqu@suse.com>]

在 2026/10/3 04:25, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> When adding a qgroup relation, if we fail to add the relation item from
> "dst" to "src", we attempt to delete the relation item from "src" to "dst"
> that we added just before, however we ignore the deletion result and if we
> failed to delete we leave an inconsistency in the quota root. So check the
> result of the deletion and if it fails, abort the transaction to avoid
> persisting an inconsistent state.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/qgroup.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index 798f21608de5..4b6c82a24bc5 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -1616,7 +1616,11 @@ int btrfs_add_qgroup_relation(struct btrfs_trans_handle *trans, u64 src, u64 dst
>   
>   	ret = add_qgroup_relation_item(trans, dst, src);
>   	if (ret) {
> -		del_qgroup_relation_item(trans, src, dst);
> +		int ret2;
> +
> +		ret2 = del_qgroup_relation_item(trans, src, dst);
> +		if (ret2 < 0)
> +			btrfs_abort_transaction(trans, ret);
>   		goto out;
>   	}
>