From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/3] btrfs: clean up space_info usage in btrfs_update_block_group
Date: Thu, 2 Mar 2023 14:46:15 +0800 [thread overview]
Message-ID: <c08edf3e-bbd3-da0f-b7e7-af42fb5e10cd@oracle.com> (raw)
In-Reply-To: <f7a7a4beb5d9f249204fbca72a04b4cd78274c18.1677705092.git.josef@toxicpanda.com>
On 3/2/23 05:14, Josef Bacik wrote:
> We do
>
> cache->space_info->counter += num_bytes;
>
> Everywhere in here. This is makes the lines longer than they need to
> be, and will be especially noticeable when I add the active tracking in,
> so add a temp variable for the space_info so this is cleaner.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Looks good.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
next prev parent reply other threads:[~2023-03-02 6:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 21:14 [PATCH 0/3] Fix active zone accounting for zoned Josef Bacik
2023-03-01 21:14 ` [PATCH 1/3] btrfs: rename BTRFS_FS_NO_OVERCOMMIT -> BTRFS_FS_ACTIVE_ZONE_TRACKING Josef Bacik
2023-03-02 6:45 ` Anand Jain
2023-03-02 10:03 ` Johannes Thumshirn
2023-03-02 14:45 ` Naohiro Aota
2023-03-01 21:14 ` [PATCH 2/3] btrfs: clean up space_info usage in btrfs_update_block_group Josef Bacik
2023-03-02 6:46 ` Anand Jain [this message]
2023-03-02 10:04 ` Johannes Thumshirn
2023-03-02 14:47 ` Naohiro Aota
2023-03-01 21:14 ` [PATCH 3/3] btrfs: handle active zone accounting properly Josef Bacik
2023-03-02 7:01 ` Naohiro Aota
2023-03-02 14:45 ` Naohiro Aota
2023-03-02 16:07 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c08edf3e-bbd3-da0f-b7e7-af42fb5e10cd@oracle.com \
--to=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox