From: Nikolay Borisov <nborisov@suse.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
clm@fb.com, David Sterba <dsterba@suse.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
"open list:BTRFS FILE SYSTEM" <linux-btrfs@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function
Date: Tue, 8 Oct 2019 10:28:06 +0300 [thread overview]
Message-ID: <c120d3a8-2e58-d109-191c-bd75ee8111b7@suse.com> (raw)
In-Reply-To: <20191008005038.12333-1-marcos.souza.org@gmail.com>
On 8.10.19 г. 3:50 ч., Marcos Paulo de Souza wrote:
> Commit 4617ea3a52cf (" Btrfs: fix necessary chunk tree space calculation
> when allocating a chunk") removed the is_allocation argument from
> check_system_chunk, since the formula for reserving the necessary space
> for allocation or removing a chunk would be the same.
>
> So, rework the comment by removing the mention of is_allocation
> argument.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/block-group.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index bf7e3f23bba7..4910921838db 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -2987,9 +2987,7 @@ static u64 get_profile_num_devs(struct btrfs_fs_info *fs_info, u64 type)
> }
>
> /*
> - * If @is_allocation is true, reserve space in the system space info necessary
> - * for allocating a chunk, otherwise if it's false, reserve space necessary for
> - * removing a chunk.
> + * Reserve space in the system space for allocating or removing a chunk
> */
> void check_system_chunk(struct btrfs_trans_handle *trans, u64 type)
> {
> --
> 2.23.0
>
>
next prev parent reply other threads:[~2019-10-08 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 0:50 [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function Marcos Paulo de Souza
2019-10-08 7:28 ` Nikolay Borisov [this message]
2019-10-08 11:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c120d3a8-2e58-d109-191c-bd75ee8111b7@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox