Re: [PATCH] btrfs-progs: dump-tree: add degraded option

[Anand Jain <anand.jain@oracle.com>]

On 03/10/2018 12:23 AM, David Sterba wrote:
> On Thu, Feb 22, 2018 at 10:00:11PM +0800, Anand Jain wrote:
>> btrfs inspect dump-tree cli picks the disk with the largest generation
>> to read the root tree, even when all the devices were not provided in
>> the cli. But in 2 disks RAID1 you may need to know what's in the disks
>> individually, so this option -x | --degraded indicates to use only the
>> given disk to dump.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>>   cmds-inspect-dump-tree.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/cmds-inspect-dump-tree.c b/cmds-inspect-dump-tree.c
>> index df44bb635c9c..587b6081df0c 100644
>> --- a/cmds-inspect-dump-tree.c
>> +++ b/cmds-inspect-dump-tree.c
>> @@ -198,6 +198,7 @@ const char * const cmd_inspect_dump_tree_usage[] = {
>>   	"-u|--uuid              print only the uuid tree",
>>   	"-b|--block <block_num> print info from the specified block only",
>>   	"-t|--tree <tree_id>    print only tree with the given id (string or number)",
>> +	"-x|--degraded          For RAID1, use the disk in the arg, do not scan for disks",
> 
> I find this confusing, degraded for kernel means 'mount with anything
> you have' while here it means 'use exactly that disk'.

  Agreed.

> Something that would reflect the "don't scan" would be IMHO better, but
> otherwise the goal of the patch makes sense.

  Hope this is better.

   -x|--noscan


Thanks, Anand


> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>