From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Marek Behun <marek.behun@nic.cz>, Qu Wenruo <wqu@suse.com>
Cc: u-boot@lists.denx.de, linux-btrfs@vger.kernel.org,
David Sterba <dsterba@suse.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH u-boot] fs: btrfs: do not fail when offset of a ROOT_ITEM is not -1
Date: Thu, 11 Feb 2021 07:24:00 +0800 [thread overview]
Message-ID: <c235e1be-706d-55e3-74fe-bdb2e586c930@gmx.com> (raw)
In-Reply-To: <20210210172144.5136d23e@nic.cz>
On 2021/2/11 上午12:21, Marek Behun wrote:
> On Wed, 10 Feb 2021 09:20:11 +0800
> Qu Wenruo <wqu@suse.com> wrote:
>
>> You're correct, the kernel is using new schema, btrfs_get_fs_root(),
>> which only requires root objectid and completely get rid of the
>> offset/type, which is far less possible to call with wrong parameters.
>>
>> It would be a good timing to sync the code between kernel and
>> progs/u-boot now.
>
> So do you agree with this patch? If so, can you add Reviewed-by? Thanks.
>
I mean, to change btrfs-progs interface to follow kernel
btrfs_get_fs_root() schema, just pass objectid, without the need for
btrfs_key.
Thanks,
Qu
next prev parent reply other threads:[~2021-02-10 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 17:33 [PATCH u-boot] fs: btrfs: do not fail when offset of a ROOT_ITEM is not -1 Marek Behún
2021-02-10 0:09 ` Qu Wenruo
2021-02-10 1:05 ` Marek Behun
2021-02-10 1:20 ` Qu Wenruo
2021-02-10 16:21 ` Marek Behun
2021-02-10 23:24 ` Qu Wenruo [this message]
2021-03-02 3:47 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c235e1be-706d-55e3-74fe-bdb2e586c930@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox