From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD813D0934 for ; Wed, 22 Apr 2026 11:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776858693; cv=none; b=fEIN5WbPKpz3caKY6WMcO3/gj3TGVkfRCuvoqreXfJHVX//FePO11aeB8jg2ZvPd6c7cdKY6s7wVeSUvIj9kmW8xpYgdp1OSynKEris2/u31DTle10rqy6/iUEO2ffCL/0f6okyXbg+3haDu+OrbXhKtEOx32Bm1RJZ8sDQx/v0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776858693; c=relaxed/simple; bh=XCRMq3Jl28lb7xVzh6vJ99+uZ69SG+aN/hdMvbNBYVc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BlGsGkIyY1FrIRkS3PaSbIzFzu61wlIywTu2OjeAmK5D7OIp/SsPGsL980BRDN9wkgEJ6iMiRt84wzUYg3zxWd2hXckNwUADYDnxFzOzPw9jYHsnRcoeZ8grrrCmsn67LUrMMxxMDvadtfVVrsBXYPuwzmHmg2fHp7C4mQHcWIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OklNU0x0; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OklNU0x0" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c76c60c7502so2339597a12.0 for ; Wed, 22 Apr 2026 04:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776858692; x=1777463492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g/ZDMUKz4uhk7JHfTz2NQ2cYjK+SrQpOAZldlPX+P6I=; b=OklNU0x00YVMKRZ/+OGO+qSdzxmMqmBbMVR138mlg7rYefDAkrydtF39KKbtrRUpi2 PABvkdCUSw+H7eCUvY4C2vcdUyW/E33+IZGWltKe2BUc8mh57SYJsBP2cZVnHgg8Fu5U cIqscv9kv8KeeNFoQBls20CpXwf+0p6xVqu32LmlAfj8GBrgkpW9xm5cR8ufIEhLmly6 /30LEIOy3NsgKe6s1mWPG5ACai2bflGm1A3H0z4MdkoI4zToAfYBXuHjsM5t5r06bJ+9 sszpCTbfK2g0sNndO9+PtSg+GA+Wmv+34867yYk9eTe0i7sqgf86JvgmHUMPww7CyHhm HKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776858692; x=1777463492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g/ZDMUKz4uhk7JHfTz2NQ2cYjK+SrQpOAZldlPX+P6I=; b=rslCP9SKa2j2e3uCch+5+qVMaWNXx4zy3TCojHmyddxmL3elkJSeqOQ5Hl27f/lNAy 07MYYbfaa+qYTK2W7CIljobHcbg1wLlHhme6KxU63Rz+8cjUIsucmZN1tbFAKA/S4Vfb zNDdQji3HyPIIYlzVZJhLumUZ0yk1mGkh4jzjkP+y1dGztQ1xOzGZMQ8JygGeooQs6vc 7viXtUDT1oGol5DQp5aMRNqg+1ZVPuMjtsmgXM6VivW6jhoClvIJId3uLrej3zGhOtqt vJKfPC+sHFO4voOVpAd0bm7guc19aihj74Dr/mdWeVjsEpQmwxuEYeY0I50V4O/2ezPC aWiQ== X-Gm-Message-State: AOJu0YxgBMPCwjCWSXALL0tV8sxN0/t62rUMQcJ/6jTzxzyCr117WYHp oHk3XjGy3HvZxKIYn1uEzwfYeVwnUTm/KkblnvMQhWCyamT8Bjodm4oN X-Gm-Gg: AeBDietK0MEACn4ZI2qEk029eKQX0L/jCUDXr9lqqAFaMg7P+zMNtTbQq5CS0zPrk6S QmcTDXaRCKVl/cIc0qMRWtH4p9u4PZIU62feq5Cku5I3JgRi9usi17x1KSbeCfeaLgaqrTWiTg7 p7KXT7mMWE+1RFKgZe90Tbi3Mt9CS/8Xwotm4CFD/x8Wsp5LzIxhFFPglKYdOBvgv5zqIeYSPcM /VR2J9TorasJjslUTxJPPWEBGgKxPepR0WRwiDWC7jtVwjl5hEdi7LqYIMxHFPE4lUM93Vg0C3P MdgF/2a5HAT3p93U3soqijN2Xs0Hc++sSbKUWUcbZ1EhrBfoS2D3GxsCZYA0ZD1/2gVyyVDaMhl xG8w3lIVBwxrj3QWlGiFMxGS8tx+BlXOsAliiU9H58ZdcK2wii8ktoRJPhfMHNt8LkcQiD0pS6J g3lawUxmluOqxRHfWcRU9yKPGq1w5TUP/ckaxR2w== X-Received: by 2002:a05:6a20:7d9f:b0:39f:3559:750d with SMTP id adf61e73a8af0-3a08cca99ddmr19877598637.31.1776858691628; Wed, 22 Apr 2026 04:51:31 -0700 (PDT) Received: from [192.168.50.90] ([116.87.14.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797701afeesm12385720a12.15.2026.04.22.04.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 04:51:31 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 19:51:28 +0800 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] common/dmlogwrites: add _require_logwrites_size helper To: Disha Goel , fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com, djwong@kernel.org, fdmanana@kernel.org, quwenruo.btrfs@gmx.com, zlang@kernel.org References: <20260414102031.74527-1-disgoel@linux.ibm.com> Content-Language: en-US From: Anand Jain In-Reply-To: <20260414102031.74527-1-disgoel@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/4/26 18:20, Disha Goel wrote: > Add a new helper function _require_logwrites_size() to check if the > LOGWRITES_DEV meets a minimum size requirement. > > This is useful for tests that use dm-log-writes with additional space > requirements, such as creating LVM snapshots during log replay or tests > that generate large amounts of logged I/O operations. > > The function takes a size parameter in KB and skips the test if > LOGWRITES_DEV is smaller than the required size. > > Signed-off-by: Disha Goel > --- > common/dmlogwrites | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/common/dmlogwrites b/common/dmlogwrites > index a27e1966..1ce2b2fb 100644 > --- a/common/dmlogwrites > +++ b/common/dmlogwrites > @@ -14,6 +14,15 @@ _require_log_writes() > _require_test_program "log-writes/replay-log" > } > > +_require_logwrites_size() > +{ > + [ $# -eq 1 ] || _fail "_require_logwrites_size: expected size param" > + > + local devsize=$(_get_device_size $LOGWRITES_DEV) > + [ $devsize -lt $1 ] && \ > + _notrun "LOGWRITES_DEV too small, ${devsize}KB < $1KB" > +} > + > # Starting from v4.15-rc1, DAX support was added to dm-log-writes, but note > # that it doesn't track the data that we write via the mmap(), so we can't do > # any data integrity checking. We can only verify that the metadata writes for _require_logwrites_size() should be designed something like this _require_log_writes_sized() { local size=$1 _require_log_writes check $size || _notrun } So, patch 2/2 can simply call `_require_log_writes_sized <>` Thanks.