Re: [PATCH 1/1] btrfs/339: test receive dump stream for different user

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/11/19 13:10, Sidong Yang 写道:
> Test receive to dump stream file from different user.
> 
> This is a regression test for the btrfs-progs commit cd933616d485
> ("btrfs-progs: receive: don't use O_NOATIME to open stream for
> dumping").
> 
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
> ---
>   tests/btrfs/339     | 32 ++++++++++++++++++++++++++++++++
>   tests/btrfs/339.out |  2 ++
>   2 files changed, 34 insertions(+)
>   create mode 100755 tests/btrfs/339
>   create mode 100644 tests/btrfs/339.out
> 
> diff --git a/tests/btrfs/339 b/tests/btrfs/339
> new file mode 100755
> index 00000000..728f3d9d
> --- /dev/null
> +++ b/tests/btrfs/339
> @@ -0,0 +1,32 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2025 Sidong Yang.  All Rights Reserved.
> +#
> +# FS QA Test 339
> +#
> +# Test btrfs receive dump stream from different user
> +#
> +. ./common/preamble
> +_begin_fstest auto quick send snapshot
> +
> +. ./common/filter
> +. ./common/quota
> +
> +_require_scratch
> +_require_user
> +
> +_fixed_by_git_commit btrfs-progs cd933616d485 \
> +	"btrfs-progs: receive: don't use O_NOATIME to open stream for dumping"
> +
> +_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
> +_scratch_mount
> +
> +$BTRFS_UTIL_PROG -q subvolume snapshot -r $SCRATCH_MNT $SCRATCH_MNT/snap | _filter_scratch

If you are using "-q" to suppress non-critical messages, you don't need 
to do the _filter_scratch call.

It's better just to redirect all output to seqres.full without "-q".

> +$BTRFS_UTIL_PROG -q send -f stream $SCRATCH_MNT/snap

Furthermore, the stream file is at the current working directory, and if 
the test case is interrupted before "rm stream" call, the file will be 
left uncleaned.

Please use $tmp or some location inside $TEST_DIR to store the send 
stream, and have a proper cleanup function.

Thanks,
Qu

> +chmod a+r stream
> +_su $qa_user -c "$BTRFS_UTIL_PROG receive --dump -f stream" >> $seqres.full
> +rm stream
> +
> +# success, all done
> +echo "Silence is golden"
> +_exit 0
> diff --git a/tests/btrfs/339.out b/tests/btrfs/339.out
> new file mode 100644
> index 00000000..293ea808
> --- /dev/null
> +++ b/tests/btrfs/339.out
> @@ -0,0 +1,2 @@
> +QA output created by 339
> +Silence is golden