linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: do not background blkdev_put()
Date: Thu, 18 Aug 2016 22:26:35 +0800	[thread overview]
Message-ID: <c2e8f393-a723-593c-9a4a-8414fe573bd6@oracle.com> (raw)
In-Reply-To: <20160818124629.GD16983@twin.jikos.cz>



On 08/18/2016 08:46 PM, David Sterba wrote:
> On Fri, Jul 22, 2016 at 06:04:53AM +0800, Anand Jain wrote:
>> From: Anand Jain <Anand.Jain@oracle.com>
>>
>> At the end of unmount/dev-delete, if the device exclusive open is not
>> actually closed, then there might be a race with another program in
>> the userland who is trying to open the device in exclusive mode and
>> it may fail for eg:
>>       unmount /btrfs; fsck /dev/x
>>       btrfs dev del /dev/x /btrfs; fsck /dev/x
>> so here background blkdev_put() is not a choice
>
> missing signed-off, I'll add it

Err.

> Reviewed-by: David Sterba <dsterba@suse.com>
>
Thanks, Anand

      reply	other threads:[~2016-08-18 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 22:04 [PATCH] btrfs: do not background blkdev_put() Anand Jain
2016-08-18 12:46 ` David Sterba
2016-08-18 14:26   ` Anand Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2e8f393-a723-593c-9a4a-8414fe573bd6@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).