Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
	Chris Mason <clm@fb.com>
Subject: Re: [PATCH v2] btrfs: fix a possible race window when allocating new extent buffers
Date: Fri, 7 Jun 2024 13:57:38 +0930	[thread overview]
Message-ID: <c3197ead-6393-4a80-9e7b-ed8eb9b8a298@gmx.com> (raw)
In-Reply-To: <20240606192722.GF18508@twin.jikos.cz>



在 2024/6/7 04:57, David Sterba 写道:
[...]
>
> Thanks. I'll pick the patch to branch for the next pull request, the fix has
> survived enough testing and we should get it to stable without further delays.
> I've edited the subject and changelog a bit, the problem is really the folio
> private protection, it is a race window fix but that does not tell much what is
> the cause. I've also added the reproducer script from Chris.
>

Mind to push the updated version to for-next?

I'd like to restart the test of larger metadata folios.
Ironically if we force larger metadata folios (one folio one metadata),
the race can also be solved, as now folio lock would kick in to prevent
the race.

Thanks,
Qu

  reply	other threads:[~2024-06-07  4:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  1:31 [PATCH v2] btrfs: fix a possible race window when allocating new extent buffers Qu Wenruo
2024-06-06 16:22 ` Filipe Manana
2024-06-06 16:52 ` Josef Bacik
2024-06-06 19:27 ` David Sterba
2024-06-07  4:27   ` Qu Wenruo [this message]
2024-06-07 13:56     ` David Sterba
2024-06-07 15:37       ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3197ead-6393-4a80-9e7b-ed8eb9b8a298@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox