Re: [PATCH] fstests: btrfs/153: Remove it from auto group

Eryu Guan
2020-02-01T07:36:58Z

On Tue, Jan 14, 2020 at 08:50:44PM +0800, Qu Wenruo wrote:
> This test case always fail after commit c6887cd11149 ("Btrfs: don't do
> nocow check unless we have to").
> As btrfs no longer checks nodatacow at buffered write time.
>
> That commits brings in a big performance enhancement, as that check is
> not cheap, but breaks qgroup, as write into preallocated space now needs
> extra space.
>
> There isn't yet a good solution (reverting that patch is not possible,
> and only check nodatacow for quota enabled case is very bug prune due to
> quite a lot code change).
>
> We may solve it using the new ticketed space reservation facility, but
> that won't come into fruit anytime soon.
>
> So let's just remove that test case from 'auto' group, but still keep
> the test case to inform we still have a lot of work to do.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>

I'd like to see an ACK from btrfs folks. Thanks!

Eryu

> ---
> tests/btrfs/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/group b/tests/btrfs/group
> index 697b6a38ea00..3c554a194742 100644
> --- a/tests/btrfs/group
> +++ b/tests/btrfs/group
> @@ -155,7 +155,7 @@
> 150 auto quick dangerous
> 151 auto quick volume
> 152 auto quick metadata qgroup send
> -153 auto quick qgroup limit
> +153 quick qgroup limit
> 154 auto quick volume
> 155 auto quick send
> 156 auto quick trim
> --
> 2.24.1
>