From: Nikolay Borisov <nborisov@suse.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, josef@toxicpanda.com
Subject: Re: [PATCH] btrfs: Reduce scope of delayed_rsv->lock in may_commit_trans
Date: Tue, 7 Nov 2017 22:42:26 +0200 [thread overview]
Message-ID: <c38c64d8-4b6b-4bd1-52a5-df9ee7b7cdd6@suse.com> (raw)
In-Reply-To: <20171107201804.GD27557@twin.jikos.cz>
On 7.11.2017 22:18, David Sterba wrote:
> On Tue, Nov 07, 2017 at 11:22:54AM +0200, Nikolay Borisov wrote:
>> After commit ('btrfs: change how we decide to commit transactions during
>
> 996478ca9c460886ac1
That commit is still not pulled by linus so is this id stable?
>
>> flushing') there is no need to hold the delayed_rsv during the
>> percpu_counter_compare call since we get the byte's snapshot earlier. So hold
>> the lock only while reading delayed_rsv
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>
> Reviewed-by: David Sterba <dsterba@suse.com>
>
next prev parent reply other threads:[~2017-11-07 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 9:22 [PATCH] btrfs: Reduce scope of delayed_rsv->lock in may_commit_trans Nikolay Borisov
2017-11-07 20:18 ` David Sterba
2017-11-07 20:42 ` Nikolay Borisov [this message]
2017-11-07 21:15 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c38c64d8-4b6b-4bd1-52a5-df9ee7b7cdd6@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).