From: Anand Jain <anand.jain@oracle.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Zorro Lang <zlang@redhat.com>
Cc: Filipe Manana <fdmanana@suse.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v6 5/9] btrfs: add fstest for stripe-tree metadata with 4k write
Date: Fri, 29 Dec 2023 17:38:02 +0530 [thread overview]
Message-ID: <c46cac6b-2c60-3602-8c35-d6b304ffb0da@oracle.com> (raw)
In-Reply-To: <37f24bda-fe2c-fd82-38eb-d5d0e3e54842@oracle.com>
>> +test _get_page_size -eq 4096 || _notrun "this tests requires 4k
>> pagesize"
>> +
>
> I made the following changes, to make this test-case run.
> Also, in 30[5,6]
>
> -----
> diff --git a/tests/btrfs/304 b/tests/btrfs/304
> index 05a4ae32639d..f1db52c1ba5c 100755
> --- a/tests/btrfs/304
> +++ b/tests/btrfs/304
> @@ -22,7 +22,7 @@ _require_btrfs_fs_feature "free_space_tree"
> _require_btrfs_free_space_tree
> _require_btrfs_no_compress
>
> -test _get_page_size -eq 4096 || _notrun "this tests requires 4k pagesize"
> +test $(_get_page_size) -eq 4096 || _notrun "this tests requires 4k
> pagesize"
>
> test_4k_write()
> {
> -------
With the above fixed and the trailing white spaces fixed
Reviewed-by: Anand Jain <anand.jain@oracle.com>
for the patchset.
next prev parent reply other threads:[~2023-12-29 12:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 11:35 [PATCH v6 0/9] fstests: add tests for btrfs' raid-stripe-tree feature Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 1/9] fstests: doc: add new raid-stripe-tree group Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 2/9] common: add filter for btrfs raid-stripe dump Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 3/9] common: add _require_btrfs_no_nodatacow helper Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 4/9] common: add _require_btrfs_free_space_tree Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 5/9] btrfs: add fstest for stripe-tree metadata with 4k write Johannes Thumshirn
2023-12-27 15:19 ` Anand Jain
2023-12-29 12:08 ` Anand Jain [this message]
2024-01-08 12:38 ` Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 6/9] btrfs: add fstest for 8k write spanning two stripes on raid-stripe-tree Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 7/9] btrfs: add fstest for writing to a file at an offset with RST Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 8/9] btrfs: add fstests to write 128k to a RST filesystem Johannes Thumshirn
2023-12-13 11:35 ` [PATCH v6 9/9] btrfs: add fstest for overwriting a file partially with RST Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c46cac6b-2c60-3602-8c35-d6b304ffb0da@oracle.com \
--to=anand.jain@oracle.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox