Re: [PATCH] Btrfs: fix build errors of extent_io.c

["Ryusuke Konishi" <konishi.ryusuke@lab.ntt.co.jp>]

2009/1/6 Chris Mason <chris.mason@oracle.com>:
> On Mon, 2009-01-05 at 12:37 -0500, Christoph Hellwig wrote:
>> On Tue, Jan 06, 2009 at 02:29:17AM +0900, Ryusuke Konishi wrote:
>> > 2009/1/6 Chris Mason <chris.mason@oracle.com>:
>> > > On Wed, 2008-12-24 at 17:56 +0900, Ryusuke Konishi wrote:
>> > >> Hi Chris,
>> > >>
>> > >> I've started to read and try btrfs, and soon met the following build
>> > >> errors.  The attached patch fixes the problem.
>> > >>
>> > >> Could you check this?
>> > >>
>> > >
>> > > Strange, I wonder why your gcc complains and mine doesn't ;)  I'll fix
>> > > these up thouhg.
>> >
>> > Because I tried it on a powerpc ;)
>> > The check of EXPORT_SYMBOL macros seems to be more strict
>> > than that of x86.
>>
>> It doesn't really matter how strict the checks are, because the exports
>> simply need to go away.  As long as the extent_map/buffer code resides
>> inside btrfs no one should be using it without either copying it or
>> moving it out of the btrfs module and into a common one first.
>
> Yes, my plan was to drop the exports.
>
> -chris

I agree with it, too.
The patch was just to let you know the problem at the time of
Chrismas.

Ryusuke