From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>, Johannes Thumshirn <jth@kernel.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] btrfs: rst: remove encoding field from stripe_extent
Date: Tue, 11 Jun 2024 16:33:19 +0000 [thread overview]
Message-ID: <c7246728-aadb-4699-8fdf-060502c1092a@wdc.com> (raw)
In-Reply-To: <20240611143651.GH18508@suse.cz>
On 11.06.24 16:37, David Sterba wrote:
> On Mon, Jun 10, 2024 at 10:40:25AM +0200, Johannes Thumshirn wrote:
>> -#define BTRFS_STRIPE_RAID5 5
>> -#define BTRFS_STRIPE_RAID6 6
>> -#define BTRFS_STRIPE_RAID1C3 7
>> -#define BTRFS_STRIPE_RAID1C4 8
>> -
>> struct btrfs_stripe_extent {
>> - __u8 encoding;
>> - __u8 reserved[7];
>> /* An array of raid strides this stripe is composed of. */
>> - struct btrfs_raid_stride strides[];
>> + __DECLARE_FLEX_ARRAY(struct btrfs_raid_stride, strides);
>
> Is there a reason to use the __ underscore macro? I see no difference
> between that and DECLARE_FLEX_ARRAY and underscore usually means that
> it's special in some way.
>
Yes, the __ version is for UAPI, like __u8 or __le32 and so on.
next prev parent reply other threads:[~2024-06-11 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 8:40 [PATCH 0/3] btrfs: rst: updates for RAID stripe tree Johannes Thumshirn
2024-06-10 8:40 ` [PATCH 1/3] btrfs: rst: remove encoding field from stripe_extent Johannes Thumshirn
2024-06-11 14:36 ` David Sterba
2024-06-11 16:33 ` Johannes Thumshirn [this message]
2024-06-13 21:23 ` David Sterba
2024-06-14 9:36 ` Johannes Thumshirn
2024-06-16 18:19 ` David Sterba
2024-06-17 6:27 ` Qu Wenruo
2024-06-10 8:40 ` [PATCH 2/3] btrfs: replace stripe extents Johannes Thumshirn
2024-06-10 19:43 ` Josef Bacik
2024-06-11 6:27 ` Johannes Thumshirn
2024-06-10 8:40 ` [PATCH 3/3] btrfs: split RAID stripes on deletion Johannes Thumshirn
2024-06-10 19:45 ` Josef Bacik
2024-06-11 6:39 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7246728-aadb-4699-8fdf-060502c1092a@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox