From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11BD71E231E; Sat, 3 Jan 2026 11:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767438655; cv=none; b=rRC5+c2yPEOckgjSYbGBfurtolZptxjYOf8ZKWi8ervMI4Ea43WKMhYFjlf6NNYhmMjLt6gIVDZ/Y0lWd8gIT16i517wkMQFSEJyhsHwu25umt4++8L8Kr3ZcBK9GWoJvESX9+1HfoI6yni7A47zN34dmAMQH2EEJWPTduIWRyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767438655; c=relaxed/simple; bh=jp68MVC+P0p1UuoNYPzbcHr6LPN+K8JU4atA5jieR/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n/fhXSWeF9/i8+6XEV8VIAqak4Bo8z91IC7JqLBhDk11vMKnPz8qOYsw3SP/Y7rvqzL/z9Dsjq0tP6/dJ+lgTSlNr/uA9vpDw1mhkmDEux1ZjDjjD7G7+MagnXl3lxzr56RentXDE59lnj+LOaxyeoEYv7L0RMMG3kzoDdvpawg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gtpV5Lwh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gtpV5Lwh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06867C113D0; Sat, 3 Jan 2026 11:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767438654; bh=jp68MVC+P0p1UuoNYPzbcHr6LPN+K8JU4atA5jieR/w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gtpV5LwhGhrXdfl38aFrNPwsxttqYVKBjkVzJbHCFG01awWWliOKdheB+Hf4xt7fP CqOlafebvGWjoA6tZDI08FKuuXkfL+AyvO7futZye0fOTuv88/W9b/Cjf9m9PeBjnE 0Y5UyRQJNX/BfkOSgBEtvfZdc7kcW8KtvxFeHomIcF/41xQ6Is24RoP0H5cpmmXjLg tCnqWUmp8NCwGom++XAcTH3W+7E7cpPBpwR0QSWn6Pmmz4+idRPaJfAZZc4RCc4/Vn FGfbl0KZ8k5SS7AUR0TgRmWtB0cXQOT+nVv4HzV7mEPLv4qCBc4PMVk8qUy2CO9Rtk C51zVShkrX+QA== Message-ID: Date: Sat, 3 Jan 2026 12:10:45 +0100 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] overflow: Update is_non_negative() and is_negative() comment To: Dan Carpenter , Randy Dunlap Cc: Miguel Ojeda , Nicolas Schier , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chris Mason , David Sterba , Kees Cook , "Gustavo A. R. Silva" , Linus Torvalds , linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org, linux-hardening@vger.kernel.org, kernel test robot References: <20251220-remove_wtype-limits-v3-0-24b170af700e@kernel.org> <20251220-remove_wtype-limits-v3-3-24b170af700e@kernel.org> <20260101-futuristic-petrel-of-ecstasy-23db5f@lindesnes> <903ba91b-f052-4b1c-827d-6292965026c5@moroto.mountain> From: Vincent Mailhol Content-Language: en-US Autocrypt: addr=mailhol@kernel.org; keydata= xjMEZluomRYJKwYBBAHaRw8BAQdAf+/PnQvy9LCWNSJLbhc+AOUsR2cNVonvxhDk/KcW7FvN JFZpbmNlbnQgTWFpbGhvbCA8bWFpbGhvbEBrZXJuZWwub3JnPsKZBBMWCgBBFiEE7Y9wBXTm fyDldOjiq1/riG27mcIFAmdfB/kCGwMFCQp/CJcFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQq1/riG27mcKBHgEAygbvORJOfMHGlq5lQhZkDnaUXbpZhxirxkAHwTypHr4A/joI 2wLjgTCm5I2Z3zB8hqJu+OeFPXZFWGTuk0e2wT4JzjgEZx4y8xIKKwYBBAGXVQEFAQEHQJrb YZzu0JG5w8gxE6EtQe6LmxKMqP6EyR33sA+BR9pLAwEIB8J+BBgWCgAmFiEE7Y9wBXTmfyDl dOjiq1/riG27mcIFAmceMvMCGwwFCQPCZwAACgkQq1/riG27mcJU7QEA+LmpFhfQ1aij/L8V zsZwr/S44HCzcz5+jkxnVVQ5LZ4BANOCpYEY+CYrld5XZvM8h2EntNnzxHHuhjfDOQ3MAkEK In-Reply-To: <903ba91b-f052-4b1c-827d-6292965026c5@moroto.mountain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/01/2026 at 11:02, Dan Carpenter wrote: > Thanks Randy, for sending this to me. I'm on the sparse list, but > I've been on vacation and haven't caught up with my email. Welcome back, hope you enjoyed your holidays! >I can easily silence this in Smatch. Thanks. I ran this locally, I can confirm that this silences the warning. So: Tested-by: Vincent Mailhol > diff --git a/check_unsigned_lt_zero.c b/check_unsigned_lt_zero.c > index bfeb3261f91d..ac3e650704ce 100644 > --- a/check_unsigned_lt_zero.c > +++ b/check_unsigned_lt_zero.c > @@ -105,7 +105,8 @@ static bool is_allowed_zero(struct expression *expr) > strcmp(macro, "STRTO_H") == 0 || > strcmp(macro, "SUB_EXTEND_USTAT") == 0 || > strcmp(macro, "TEST_CASTABLE_TO_TYPE_VAR") == 0 || > - strcmp(macro, "TEST_ONE_SHIFT") == 0) > + strcmp(macro, "TEST_ONE_SHIFT") == 0 || > + strcmp(macro, "check_shl_overflow") == 0) But, for the long term, wouldn't it better to just ignore all the code coming from macro extensions instead of maintaining this allow-list? > return true; > return false; > } Yours sincerely, Vincent Mailhol