From: Johannes Thumshirn <jthumshirn@suse.de>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/8] btrfs: extent-tree: Open-code process_func in __btrfs_mod_ref
Date: Wed, 12 Dec 2018 10:40:57 +0100 [thread overview]
Message-ID: <c8dadde8-611a-e402-6b1f-495847164028@suse.de> (raw)
In-Reply-To: <20181212073102.7736-3-wqu@suse.com>
On 12/12/2018 08:30, Qu Wenruo wrote:
> The process_func is never a function hook used anywhere else.
>
Hmm this sounds odd, maybe something like:
The process_func function pointer is local to __btrfs_mod_ref() and
points to either btrfs_inc_extent_ref() or btrfs_free_extent().
> Open code it to make later delayed ref refactor easier, so we can
> refactor btrfs_inc_extent_ref() and btrfs_free_extent() in different
> patches.
Otherwise:
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-12-12 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 7:30 [PATCH v2 0/8] btrfs: Refactor delayed ref parameter list Qu Wenruo
2018-12-12 7:30 ` [PATCH v2 1/8] btrfs: delayed-ref: Introduce better documented delayed ref structures Qu Wenruo
2018-12-12 9:31 ` Johannes Thumshirn
2018-12-12 11:01 ` [PATCH v2.1 " Qu Wenruo
2018-12-12 7:30 ` [PATCH v2 2/8] btrfs: extent-tree: Open-code process_func in __btrfs_mod_ref Qu Wenruo
2018-12-12 9:40 ` Johannes Thumshirn [this message]
2018-12-12 10:07 ` Qu Wenruo
2018-12-12 11:01 ` [PATCH v2.1 " Qu Wenruo
2018-12-12 7:30 ` [PATCH v2 3/8] btrfs: delayed-ref: Use btrfs_ref to refactor btrfs_add_delayed_tree_ref() Qu Wenruo
2018-12-12 7:30 ` [PATCH v2 4/8] btrfs: delayed-ref: Use btrfs_ref to refactor btrfs_add_delayed_data_ref() Qu Wenruo
2018-12-12 7:30 ` [PATCH v2 5/8] btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod() Qu Wenruo
2018-12-12 7:31 ` [PATCH v2 6/8] btrfs: extent-tree: Use btrfs_ref to refactor add_pinned_bytes() Qu Wenruo
2018-12-12 7:31 ` [PATCH v2 7/8] btrfs: extent-tree: Use btrfs_ref to refactor btrfs_inc_extent_ref() Qu Wenruo
2018-12-12 7:31 ` [PATCH v2 8/8] btrfs: extent-tree: Use btrfs_ref to refactor btrfs_free_extent() Qu Wenruo
2018-12-12 12:42 ` [PATCH v2 0/8] btrfs: Refactor delayed ref parameter list David Sterba
2018-12-12 13:21 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8dadde8-611a-e402-6b1f-495847164028@suse.de \
--to=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox