From: Nikolay Borisov <nborisov@suse.com>
To: zhong jiang <zhongjiang@huawei.com>,
clm@fb.com, jbacik@fb.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Remove uneeded variable "err"
Date: Sun, 5 Aug 2018 22:14:29 +0300 [thread overview]
Message-ID: <c9f07f02-38c0-7491-3b48-0dda20f60d13@suse.com> (raw)
In-Reply-To: <1533481371-21349-1-git-send-email-zhongjiang@huawei.com>
On 5.08.2018 18:02, zhong jiang wrote:
>
> zhong jiang (3):
> fs/btrfs/disk-io: Remove unneeded variable "err"
> fs/btrfs/extent-tree: remove redudant variable "err"
> fs/btrfs/tree-log: remove the unneeded variable "err"
>
> fs/btrfs/disk-io.c | 12 ++++--------
> fs/btrfs/extent-tree.c | 6 ++----
> fs/btrfs/tree-log.c | 5 +----
> fs/btrfs/tree-log.h | 2 +-
> 4 files changed, 8 insertions(+), 17 deletions(-)
>
NAK on the whole series on the basis of using a bulk commit message
which doesn't really describe the changes of each individual commit. If
you want those changes to eventually be merged resubmit the series with
individual reasoning for every commit.
next prev parent reply other threads:[~2018-08-05 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 15:02 [PATCH 0/3] Remove uneeded variable "err" zhong jiang
2018-08-05 15:02 ` [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded " zhong jiang
2018-08-05 15:27 ` Joe Perches
2018-08-06 2:39 ` zhong jiang
2018-08-05 19:13 ` Nikolay Borisov
2018-08-06 2:42 ` zhong jiang
2018-08-05 15:02 ` [PATCH 2/3] fs/btrfs/extent-tree: remove redudant " zhong jiang
2018-08-05 15:02 ` [PATCH 3/3] fs/btrfs/tree-log: remove the unneeded " zhong jiang
2018-08-05 19:14 ` Nikolay Borisov [this message]
2018-08-06 2:37 ` [PATCH 0/3] Remove uneeded " zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f07f02-38c0-7491-3b48-0dda20f60d13@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).