Re: [PATCH 00/15] Btrfs-progs offline scrub

[Marco Lorenzo Crociani <marcoc@prismatelecomtesting.com>]

On 20/07/2017 05:39, Qu Wenruo wrote:
> 
> 
> On 2017年07月20日 00:45, Marco Lorenzo Crociani wrote:
>> On 18/07/2017 08:33, Gu Jinxiang wrote:
>>> For any one who wants to try it, it can be get from my repo:
>>> https://github.com/gujx2017/btrfs-progs/tree/offline_scrub
>>>
>>
>> Hi,
>> I'm getting this error during make:
>>
>>      [CC]     csum.o
>> csum.c: In function ‘btrfs_read_data_csums’:
>> csum.c:119:3: error: ‘for’ loop initial declarations are only allowed 
>> in C99 mode
>>     for (u32 i = 0; i != final_len / csum_size; i++)
>>     ^
> 
> Oh, this is indeed a problem.
> Introduced in the version which bitmap for csum is introduced.
> 
> Should be fixed to use c90 standard (at least gnu90).
> 
>> csum.c:119:3: note: use option -std=c99 or -std=gnu99 to compile your 
>> code
>> make: *** [csum.o] Errore 1
>>
>>
>> git clone https://github.com/gujx2017/btrfs-progs.git
>> git checkout offline_scrub
>> ./autogen.sh
>> ./configure
>> make
>>
>> CentOS 7.3
>> kernel 4.12
> 
> Seems to be related to gcc version.
> Newer gcc use higher std which doesn't have such problem, while gcc 4.8 
> is still using lower standard and will print output such warning.
> 
> I'll try to enhance the Makefile to use gnu90 standard to avoid such 
> problem.
> 
> Thanks,
> Qu
> 
> 
> 
>>
>> No problem compiling official btrfs-progs v4.11.1
>>
>> Regards,
>>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Hi Qu,
now I got only a warning:

cmds-subvolume.c: In function 'cmd_subvol_show':
cmds-subvolume.c:964:7: warning: 'rootid_arg' may be used uninitialized 
in this function [-Wmaybe-uninitialized]
    ret = get_subvol_info_by_rootid(fullpath, &get_ri, rootid_arg);

I tried to run scrub on an umounted btrfs raid6 filesystem but instead 
of "ERROR: '/dev/sda1' is not a mounted btrfs device" I got:

btrfs scrub start --offline /dev/sda1
couldn't open RDWR because of unsupported option features (3).
ERROR: cannot open file system
Segmentation fault (core dumped)

[1182841.663283] btrfs[30198]: segfault at 46474e548 ip 00007f0eeeac838c 
sp 00007fff35a52c58 error 4 in libc-2.17.so[7f0eeea48000+1b7000]

Regards,

-- 
Marco Crociani