From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D594337059A for ; Tue, 26 Aug 2025 15:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756222914; cv=none; b=qiLsdmwXOTIo3yHs5n/wvpNGMELO9vUvRVkHfdbUr2VnH6weOM7VDbuPmrTHk6oRJ1yxdv4qzRNntFfowrqp4BCyo9Mq2TCwPwUa8zLGQJIzdxgvqzR28seyTSicrGnSC0f6j+HxCkcrmMyBJaaXoTvGfuOqrKL8XK1hE2SmXuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756222914; c=relaxed/simple; bh=dwwe0MEH5iO3x5aF5QurpKCYlNFdYiCh2i6JCishoj4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pjfyEzFd3gyVqT++ZA1KQglqZqWuVkI+lGnP9isAxG7hl3e9vWqERERWyKEAC8XK7AQoC9h23ZbcVuLAUD132vkAhUPmaVKB1OmzM7GY+Z1yDq/sq/DayZpZvlSrMxTVecj75gBNs7WxTIqSmgnThwUtUTdi7x08pLzqQT2IU20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=none smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b=du07Fhm+; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="du07Fhm+" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7200a651345so22682487b3.1 for ; Tue, 26 Aug 2025 08:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1756222912; x=1756827712; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=yqvplDu+lNSK1bVRdwN5sEI2iN4Y4F8Nug6abxM7ea0=; b=du07Fhm+E2K75A21FLUay2gY/LIECLDwj8QJpWSLT7JEI1eYR/PzKjv9AjIMUAf+3Y 0mQyMgg26Y+H5drT1jRmdaTurj79cVC4zl+yNoF+SyXJOrSR8tlTcsbHyeCr0OqeeEr2 g5wnR7B7nVP50zr+WRcdoT8MQWTVYTZ+BrM1HqoNHvtdKCTP/LGgri6n6gz/zJOU6fnO f0Hf7bCn3xUYy2SpN28T5B8cWL6ZEuQck6b5rhndsVyIz69FYDYg/0bitHGlJmD+a3Zq zi+KbNH7jLO6Mnc+dpu9whKOdXv8DtVurbaJZdq624RXiQE1gWtjCVBWShg010G51Zui LfKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756222912; x=1756827712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yqvplDu+lNSK1bVRdwN5sEI2iN4Y4F8Nug6abxM7ea0=; b=Qbb4r6JhxwaEw4bU+zqzlC1w5k7rj0R9A0r+Xkmt8T9YAPOBTcu43MM4PDSgvC2wka 4eM4HKji8z2SkTWgKAyAOEfKewMKp/cFMcSobWEOLu/2KFQ6xgO9PLDJlqphFKB68DCW SfnpfCjjo63TYmQOOXcFqHnE2Bw9OAKvcl0SCXGISktEv53fL2zWn09bSUaghgB4/sJT m901INnYHhSquZmfzKwspu7K44TU91bOtGBuBfovAQnotsfB7SZS7C3p6dXVfbYEpE+q YjhsDTVz143PblizwTMwHblVyrn3ha2pIp9iVjKuM12txcU1Cuqiu+GtzLagWZLl57tM N46w== X-Forwarded-Encrypted: i=1; AJvYcCUCjqCNlGckpPLtob3jbHMQyD9SIGIXd2xPz7tijIR70qQEcyDtR2CqhKitEFD+3PyDp/CJdB49xyq2UA==@vger.kernel.org X-Gm-Message-State: AOJu0YwtMOw7YkhL4lQNbdBZz+Cz+QUEqP7GMROku7P7XvdU752PFRsk R1rzQ8xWULRK3em0+KH/SAWQDse75yWGd+1MdxuqnOl10Nc4aH+/xXi+lk2LS4dHd4g= X-Gm-Gg: ASbGncs6MdITYl/jYDJgFd/al76HeZYEkieeaChO9a6ETnKNrozzjLot0o4fsUlTVdJ yS8OzZm5P2dAYP5R+VtyBWGBMG5WL7IapW8xwvxFi8D2VoQK1Jiin7p79nHOQtvGr+HliWamGsI QEAkvJF+GwFUEadiMjmX4igvBVKhr13woUezWlc4MTScxdS/1S/MqBxBbXvtpmLPZe6x/y6APbk Sx+nRyPJ91LEZpyTj66diDXya3JRNrZT+6m13nwf9l6Trl3wBt/scWNaOVcnScrH/Ud4aluVTxS hVSFSsGN0xvpwWjnotgNLjLenaw1CLs2Ce8IIj5wmEwb/aP0C46A5Qm4n9K8paoiWNJq2mmFZow kJ/Hhl3GVBNoZEuuTOdnPQTX2IuH/db1x5/iUPDLftPn1nIKO42SFXhfanDo= X-Google-Smtp-Source: AGHT+IEmTijuWh+ST4YjRGo7H4pufM7FApdnNjecK9pfpFaUwQCk/e/q5IjGGvh2/UXNpr28Nq68Jg== X-Received: by 2002:a05:690c:2606:b0:721:2c21:3614 with SMTP id 00721157ae682-72132cd7378mr19923627b3.22.1756222911738; Tue, 26 Aug 2025 08:41:51 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-5f65a223d29sm2530427d50.5.2025.08.26.08.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 08:41:50 -0700 (PDT) From: Josef Bacik To: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, brauner@kernel.org, viro@ZenIV.linux.org.uk, amir73il@gmail.com Subject: [PATCH v2 43/54] fs: change inode_is_dirtytime_only to use refcount Date: Tue, 26 Aug 2025 11:39:43 -0400 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We don't need the I_WILL_FREE|I_FREEING check, we can use the refcount to see if the inode is valid. Signed-off-by: Josef Bacik --- include/linux/fs.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index b13d057ad0d7..531a6d0afa75 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2628,6 +2628,11 @@ static inline void mark_inode_dirty_sync(struct inode *inode) __mark_inode_dirty(inode, I_DIRTY_SYNC); } +static inline int icount_read(const struct inode *inode) +{ + return refcount_read(&inode->i_count); +} + /* * Returns true if the given inode itself only has dirty timestamps (its pages * may still be dirty) and isn't currently being allocated or freed. @@ -2639,8 +2644,8 @@ static inline void mark_inode_dirty_sync(struct inode *inode) */ static inline bool inode_is_dirtytime_only(struct inode *inode) { - return (inode->i_state & (I_DIRTY_TIME | I_NEW | - I_FREEING | I_WILL_FREE)) == I_DIRTY_TIME; + return (inode->i_state & (I_DIRTY_TIME | I_NEW)) == I_DIRTY_TIME && + icount_read(inode); } extern void inc_nlink(struct inode *inode); @@ -3432,11 +3437,6 @@ static inline void __iget(struct inode *inode) refcount_inc(&inode->i_count); } -static inline int icount_read(const struct inode *inode) -{ - return refcount_read(&inode->i_count); -} - extern void iget_failed(struct inode *); extern void clear_inode(struct inode *); extern void __destroy_inode(struct inode *); -- 2.49.0