From: Anand Jain <anand.jain@oracle.com>
To: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: move the bi_sector assingment out of btrfs_add_compressed_bio_pages
Date: Thu, 16 Mar 2023 16:59:17 +0800 [thread overview]
Message-ID: <cb59c00a-9083-daed-99f0-91ba399d5f99@oracle.com> (raw)
In-Reply-To: <20230314165110.372858-2-hch@lst.de>
On 3/15/23 00:51, Christoph Hellwig wrote:
> Adding pages to a bio has nothing to do with the sector. Move the
> assignment to the two callers in preparation for cleaning up
> btrfs_add_compressed_bio_pages.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
next prev parent reply other threads:[~2023-03-16 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 16:51 cleanup btrfs_add_compressed_bio_pages Christoph Hellwig
2023-03-14 16:51 ` [PATCH 1/2] btrfs: move the bi_sector assingment out of btrfs_add_compressed_bio_pages Christoph Hellwig
2023-03-16 8:59 ` Anand Jain [this message]
2023-03-14 16:51 ` [PATCH 2/2] btrfs: btrfs_add_compressed_bio_pages Christoph Hellwig
2023-03-16 8:57 ` Anand Jain
2023-03-16 15:13 ` Christoph Hellwig
2023-03-15 18:45 ` cleanup btrfs_add_compressed_bio_pages David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb59c00a-9083-daed-99f0-91ba399d5f99@oracle.com \
--to=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox