Re: [PATCH 01/11] btrfs: don't call bioset_integrity_create for btrfs_bioset

[Anand Jain <anand.jain@oracle.com>]

On 06/08/2022 16:03, Christoph Hellwig wrote:
> btrfs never uses bio integrity data itself, so don't allocate
> the integrity pools for btrfs_bioset.
> 

  (I couldn't catch up with v1 / v2, sorry for the late comments).

  Two questions:

  This patch is a revert of the commit b208c2f7ceaf ("btrfs: Fix crash 
due to not allocating integrity data for a set"). So nowadays, integrity 
data pool allocation is not mandatory?

  Why not complete the support of bio integrity metadata instead?

Thanks, Anand

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Tested-by: Nikolay Borisov <nborisov@suse.com>
> Tested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>   fs/btrfs/extent_io.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 6e8e936a8a1ef..ca8b79d991f5e 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -255,14 +255,8 @@ int __init extent_io_init(void)
>   			BIOSET_NEED_BVECS))
>   		goto free_buffer_cache;
>   
> -	if (bioset_integrity_create(&btrfs_bioset, BIO_POOL_SIZE))
> -		goto free_bioset;
> -
>   	return 0;
>   
> -free_bioset:
> -	bioset_exit(&btrfs_bioset);
> -
>   free_buffer_cache:
>   	kmem_cache_destroy(extent_buffer_cache);
>   	extent_buffer_cache = NULL;