Re: [PATCH v2] btrfs: do not skip re-registration for the mounted device

[Anand Jain <anand.jain@oracle.com>]

>>>> $ ./check btrfs/14[6-9] btrfs/15[8-9]
>>>>

The stale fsid matches the testcase btrfs/146.
Unfortunately, the failure is inconsistent.
I will take another look tomorrow.

Thanks, Anand


>>>> Thanks, with this I can reproduce it and have some ideas what could go
>>>> wrong.
>>>
>>> Thanks indeed.
>>
>> I tested the following, it fixes the fsid problems and has passed full
>> fstests run. The temp-fsid test coverage needs to be done still.
>>
>> @@ -1388,6 +1388,10 @@ struct btrfs_device 
>> *btrfs_scan_one_device(const char *path, blk_mode_t flags,
>>          if (ret)
>>                  btrfs_warn(NULL, "lookup bdev failed for path %s: %d",
>>                             path, ret);
>> +       if (devt) {
>> +               printk(KERN_ERR "free stale devt (for path %s)\n", path);
>> +               btrfs_free_stale_devices(devt, NULL);
>> +       }
> 
> Right. I had this in mind to check for the stale devices. I'll do.
> 
> Anand