From: Nikolay Borisov <nborisov@suse.com>
To: josef@toxicpanda.com, linux-btrfs@vger.kernel.org, kernel-team@fb.com
Cc: Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH][v2] btrfs: change how we decide to commit transactions during flushing
Date: Fri, 25 Aug 2017 11:32:21 +0300 [thread overview]
Message-ID: <cfc2e650-b161-1cc2-1b8b-831f1acf282c@suse.com> (raw)
In-Reply-To: <703e4090-1bd7-afd7-ecb6-a4f07047d823@suse.com>
On 24.08.2017 17:43, Nikolay Borisov wrote:
>
>
> On 22.08.2017 23:00, josef@toxicpanda.com wrote:
>> From: Josef Bacik <jbacik@fb.com>
>>
>> Nikolay reported that generic/273 was failing currently with ENOSPC.
>> Turns out this is because we get to the point where the outstanding
>> reservations are greater than the pinned space on the fs. This is a
>> mistake, previously we used the current reservation amount in
>> may_commit_transaction, not the entire outstanding reservation amount.
>> Fix this to find the minimum byte size needed to make progress in
>> flushing, and pass that into may_commit_transaction. From there we can
>> make a smarter decision on whether to commit the transaction or not.
>> This fixes the failure in generic/273.
>>
>> Reported-by: Nikolay Borisov <nborisov@suse.com>
>> Signed-off-by: Josef Bacik <jbacik@fb.com>
>
> Reviewed-and-tested-by: Nikolay Borisov <nborisov@suse.com>
For this commit we might also add:
Fixes: 957780eb2788 ("Btrfs: introduce ticketed enospc infrastructure")
Cc: stable@vger.kernel.org # 4.8
next prev parent reply other threads:[~2017-08-25 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 20:00 [PATCH][v2] btrfs: change how we decide to commit transactions during flushing josef
2017-08-24 14:43 ` Nikolay Borisov
2017-08-25 8:32 ` Nikolay Borisov [this message]
2017-09-25 14:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfc2e650-b161-1cc2-1b8b-831f1acf282c@suse.com \
--to=nborisov@suse.com \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).