linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.cz>
Subject: [PATCH 0/3] Better transaction abort reports
Date: Fri, 24 Apr 2015 19:11:51 +0200	[thread overview]
Message-ID: <cover.1429894863.git.dsterba@suse.cz> (raw)

Hi,

patch #1 moves the WARN at transaction abort time to the callsite (via macro).
That way we get the exact location of the error and not the common location.
This is supposed to help debugging and screening report, but the change comes
at some cost and increases the resulting asm code.

I vote for better error reports, the .text grows all the time anyway. Patch #2
adds some compiler hints so the error blocks are likely to be put out of the
hot paths.

Available in

  git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git dev/abort-onsite

David Sterba (3):
  btrfs: report exact callsite where transaction abort occurs
  btrfs: add 'cold' compiler annotations to all error handling functions
  btrfs: fix warnings after changes in btrfs_abort_transaction

 fs/btrfs/ctree.h   | 16 +++++++++++++---
 fs/btrfs/ioctl.c   |  2 +-
 fs/btrfs/super.c   | 11 +++--------
 fs/btrfs/volumes.c |  6 +++---
 4 files changed, 20 insertions(+), 15 deletions(-)

-- 
2.1.3


             reply	other threads:[~2015-04-24 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 17:11 David Sterba [this message]
2015-04-24 17:11 ` [PATCH 1/3] btrfs: report exact callsite where transaction abort occurs David Sterba
2015-04-24 17:11 ` [PATCH 2/3] btrfs: add 'cold' compiler annotations to all error handling functions David Sterba
2015-04-24 17:12 ` [PATCH 3/3] btrfs: fix warnings after changes in btrfs_abort_transaction David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1429894863.git.dsterba@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).