linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>, clm@fb.com
Subject: [PULL][PATCH 0/6] Barriers around waitqueue_active (V2)
Date: Sun, 11 Oct 2015 19:50:17 +0200	[thread overview]
Message-ID: <cover.1444579885.git.dsterba@suse.com> (raw)

Hi,

I've updated the main patch according to your comments in
https://www.mail-archive.com/linux-btrfs%40vger.kernel.org/msg42551.html

though with one exception, the barrier in btrfs_bio_counter_sub which seems
to be in performance sensitive context but I did not find a good way how
determine that dev-replace is running. It's protected by the shared
satus of 'mutually_exclusive_operation_running' and we'd have to do some
other checks that would also imply some performance drop. I hope it's ok
to skipt that one for now, the remaining new barriers look safe and the rest
is documenting the existing ones.

Please consider pulling this for the 4.4 cycle. Thanks.

----------------------------------------------------------------
The following changes since commit 9ffecb10283508260936b96022d4ee43a7798b4c:

  Linux 4.3-rc3 (2015-09-27 07:50:08 -0400)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git fix/waitqueue-barriers

for you to fetch changes up to ee86395458072760d62e66aad10a5e9e8902b8cf:

  btrfs: comment the rest of implicit barriers before waitqueue_active (2015-10-10 18:42:00 +0200)

----------------------------------------------------------------
David Sterba (6):
      btrfs: remove waitqueue_active check from btrfs_rm_dev_replace_unblocked
      btrfs: add barrier for waitqueue_active in clear_btree_io_tree
      btrfs: comment waitqueue_active implied by locks
      btrfs: add comments to barriers before waitqueue_active
      btrfs: remove extra barrier before waitqueue_active
      btrfs: comment the rest of implicit barriers before waitqueue_active

 fs/btrfs/compression.c   |  3 +++
 fs/btrfs/delayed-inode.c |  4 ++++
 fs/btrfs/dev-replace.c   |  3 +--
 fs/btrfs/disk-io.c       |  3 +++
 fs/btrfs/extent-tree.c   |  3 +--
 fs/btrfs/inode.c         |  3 +++
 fs/btrfs/locking.c       | 12 ++++++++++++
 fs/btrfs/ordered-data.c  |  6 ++++++
 fs/btrfs/raid56.c        |  6 +++++-
 fs/btrfs/transaction.c   |  9 +++++++++
 fs/btrfs/tree-log.c      | 14 ++++++++++++--
 fs/btrfs/volumes.c       |  3 +++
 12 files changed, 62 insertions(+), 7 deletions(-)

             reply	other threads:[~2015-10-11 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 17:50 David Sterba [this message]
2015-10-11 17:50 ` [PATCH 1/6] btrfs: remove waitqueue_active check from btrfs_rm_dev_replace_unblocked David Sterba
2015-10-11 17:50 ` [PATCH 2/6] btrfs: add barrier for waitqueue_active in clear_btree_io_tree David Sterba
2015-10-11 17:50 ` [PATCH 3/6] btrfs: comment waitqueue_active implied by locks David Sterba
2015-10-11 17:50 ` [PATCH 4/6] btrfs: add comments to barriers before waitqueue_active David Sterba
2015-10-11 17:50 ` [PATCH 5/6] btrfs: remove extra barrier " David Sterba
2015-10-11 17:50 ` [PATCH 6/6] btrfs: comment the rest of implicit barriers " David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1444579885.git.dsterba@suse.com \
    --to=dsterba@suse.com \
    --cc=clm@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).