From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 00/29] Cleanup of unused parameters
Date: Mon, 13 Feb 2017 10:33:21 +0100 [thread overview]
Message-ID: <cover.1486977711.git.dsterba@suse.com> (raw)
There are quite a few places where function parameters are unused and there's
no reason to keep them. The notable exceptions are callbacks that must match a
given prototype. There are several cases where the parameter has not been
removed after refactoring or other changes, but I'm more disappointed by the
numerous cases where parameters were added but never used.
I haven't measured the effects on runtime stack consumption, the estimate
savings can be counted in tens of bytes.
Found by 'make ccflags-y=-Wunused-parameter', applies on top of my current 4.11
queue.
David Sterba (29):
btrfs: remove unused parameter from read_block_for_search
btrfs: remove unused parameter from check_async_write
btrfs: remove unused parameter from clean_tree_block
btrfs: remove unused parameter from split_item
btrfs: remove unused parameter from write_dev_supers
btrfs: merge two superblock writing helpers
btrfs: remove unused parameter from __push_leaf_right
btrfs: remove unused parameter from __push_leaf_left
btrfs: remove unused parameter from btrfs_subvolume_release_metadata
btrfs: remove unused parameter from btrfs_prepare_extent_commit
btrfs: remove unused parameter from btrfs_check_super_valid
btrfs: remove unused parameter from tree_move_down
btrfs: remove unused parameter from tree_move_next_or_upnext
btrfs: remove unused parameter from submit_extent_page
btrfs: remove unused parameter from update_nr_written
btrfs: remove unused parameter from add_pending_csums
btrfs: remove unused parameter from extent_write_cache_pages
btrfs: remove unused parameter from btrfs_fill_super
btrfs: remove unused parameter from __btrfs_alloc_chunk
btrfs: remove unused parameter from init_first_rw_device
btrfs: remove unused parameter from create_snapshot
btrfs: remove unused parameters from scrub_setup_wr_ctx
btrfs: remove unused parameter from __add_inline_refs
btrfs: remove unused parameters from btrfs_cmp_data
btrfs: remove unused parameter from clone_copy_inline_extent
btrfs: remove unused parameter from __add_inode_ref
btrfs: remove unused parameter from cleanup_write_cache_enospc
btrfs: remove unused parameters from __btrfs_write_out_cache
btrfs: remove unused parameter from adjust_slots_upwards
fs/btrfs/backref.c | 5 ++---
fs/btrfs/ctree.c | 51 ++++++++++++++++++++-------------------------
fs/btrfs/ctree.h | 6 ++----
fs/btrfs/disk-io.c | 29 +++++++++-----------------
fs/btrfs/disk-io.h | 6 ++----
fs/btrfs/extent-tree.c | 10 ++++-----
fs/btrfs/extent_io.c | 21 ++++++++-----------
fs/btrfs/free-space-cache.c | 16 +++++---------
fs/btrfs/free-space-tree.c | 2 +-
fs/btrfs/inode.c | 6 ++----
fs/btrfs/ioctl.c | 25 +++++++++-------------
fs/btrfs/qgroup.c | 7 +++----
fs/btrfs/scrub.c | 10 +++------
fs/btrfs/super.c | 5 ++---
fs/btrfs/transaction.c | 4 ++--
fs/btrfs/tree-log.c | 11 +++++-----
fs/btrfs/volumes.c | 18 +++++++---------
17 files changed, 92 insertions(+), 140 deletions(-)
--
2.10.1
next reply other threads:[~2017-02-13 9:33 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 9:33 David Sterba [this message]
2017-02-13 9:33 ` [PATCH 01/29] btrfs: remove unused parameter from read_block_for_search David Sterba
2017-02-14 0:59 ` Liu Bo
2017-02-14 1:03 ` Qu Wenruo
2017-02-14 1:09 ` Liu Bo
2017-02-13 9:33 ` [PATCH 02/29] btrfs: remove unused parameter from check_async_write David Sterba
2017-02-15 20:41 ` Liu Bo
2017-02-13 9:33 ` [PATCH 03/29] btrfs: remove unused parameter from clean_tree_block David Sterba
2017-02-15 21:12 ` Liu Bo
2017-02-13 9:33 ` [PATCH 04/29] btrfs: remove unused parameter from split_item David Sterba
2017-02-15 20:43 ` Liu Bo
2017-02-13 9:33 ` [PATCH 05/29] btrfs: remove unused parameter from write_dev_supers David Sterba
2017-02-14 1:59 ` Liu Bo
2017-02-13 9:33 ` [PATCH 06/29] btrfs: merge two superblock writing helpers David Sterba
2017-02-15 21:05 ` Liu Bo
2017-02-13 9:33 ` [PATCH 07/29] btrfs: remove unused parameter from __push_leaf_right David Sterba
2017-02-15 21:14 ` Liu Bo
2017-02-13 9:33 ` [PATCH 08/29] btrfs: remove unused parameter from __push_leaf_left David Sterba
2017-02-15 21:18 ` Liu Bo
2017-02-13 9:33 ` [PATCH 09/29] btrfs: remove unused parameter from btrfs_subvolume_release_metadata David Sterba
2017-02-15 21:17 ` Liu Bo
2017-02-13 9:33 ` [PATCH 10/29] btrfs: remove unused parameter from btrfs_prepare_extent_commit David Sterba
2017-02-15 21:20 ` Liu Bo
2017-02-13 9:33 ` [PATCH 11/29] btrfs: remove unused parameter from btrfs_check_super_valid David Sterba
2017-02-14 2:11 ` Liu Bo
2017-02-14 11:42 ` David Sterba
2017-02-14 18:44 ` Liu Bo
2017-02-13 9:33 ` [PATCH 12/29] btrfs: remove unused parameter from tree_move_down David Sterba
2017-02-15 21:21 ` Liu Bo
2017-02-13 9:34 ` [PATCH 13/29] btrfs: remove unused parameter from tree_move_next_or_upnext David Sterba
2017-02-15 21:22 ` Liu Bo
2017-02-13 9:34 ` [PATCH 14/29] btrfs: remove unused parameter from submit_extent_page David Sterba
2017-02-14 19:10 ` Liu Bo
2017-02-15 15:17 ` David Sterba
2017-02-13 9:34 ` [PATCH 15/29] btrfs: remove unused parameter from update_nr_written David Sterba
2017-02-15 21:22 ` Liu Bo
2017-02-13 9:34 ` [PATCH 16/29] btrfs: remove unused parameter from add_pending_csums David Sterba
2017-02-15 21:23 ` Liu Bo
2017-02-13 9:34 ` [PATCH 17/29] btrfs: remove unused parameter from extent_write_cache_pages David Sterba
2017-02-14 19:35 ` Liu Bo
2017-02-15 15:30 ` David Sterba
2017-02-15 20:38 ` Liu Bo
2017-02-13 9:34 ` [PATCH 18/29] btrfs: remove unused parameter from btrfs_fill_super David Sterba
2017-02-15 21:27 ` Liu Bo
2017-02-13 9:34 ` [PATCH 19/29] btrfs: remove unused parameter from __btrfs_alloc_chunk David Sterba
2017-02-15 21:28 ` Liu Bo
2017-02-13 9:34 ` [PATCH 20/29] btrfs: remove unused parameter from init_first_rw_device David Sterba
2017-02-15 21:30 ` Liu Bo
2017-02-13 9:34 ` [PATCH 21/29] btrfs: remove unused parameter from create_snapshot David Sterba
2017-02-14 19:36 ` Liu Bo
2017-02-13 9:34 ` [PATCH 22/29] btrfs: remove unused parameters from scrub_setup_wr_ctx David Sterba
2017-02-15 21:29 ` Liu Bo
2017-02-13 9:34 ` [PATCH 23/29] btrfs: remove unused parameter from __add_inline_refs David Sterba
2017-02-15 21:32 ` Liu Bo
2017-02-13 9:34 ` [PATCH 24/29] btrfs: remove unused parameters from btrfs_cmp_data David Sterba
2017-02-14 19:40 ` Liu Bo
2017-02-13 9:34 ` [PATCH 25/29] btrfs: remove unused parameter from clone_copy_inline_extent David Sterba
2017-02-16 0:10 ` Liu Bo
2017-02-13 9:34 ` [PATCH 26/29] btrfs: remove unused parameter from __add_inode_ref David Sterba
2017-02-16 0:08 ` Liu Bo
2017-02-13 9:34 ` [PATCH 27/29] btrfs: remove unused parameter from cleanup_write_cache_enospc David Sterba
2017-02-15 21:33 ` Liu Bo
2017-02-13 9:34 ` [PATCH 28/29] btrfs: remove unused parameters from __btrfs_write_out_cache David Sterba
2017-02-14 20:19 ` Liu Bo
2017-02-13 9:34 ` [PATCH 29/29] btrfs: remove unused parameter from adjust_slots_upwards David Sterba
2017-02-16 0:12 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1486977711.git.dsterba@suse.com \
--to=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).