From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/4][v2] Lockdep fixes
Date: Tue, 1 Sep 2020 17:40:34 -0400 [thread overview]
Message-ID: <cover.1598996236.git.josef@toxicpanda.com> (raw)
v1->v2:
- Included the add_missing_dev patch in the series.
- Added a patch to kill the rcu protection for fs_info->space_info.
- Fixed the raid sysfs init stuff to be completely out of link_block_group, as
it causes a lockdep splat with the rwsem conversion.
Hello,
These are the last two lockdep splats I'm able to see in my testing. We have
like 4 variations of the same lockdep splat that's addressed by
btrfs: do not create raid sysfs entries under chunk_mutex
Basically this particular dependency pulls in the kernfs_mutex under the
chunk_mutex, and so we have like 4 issues in github with slightly different
splats, but are all fixed by that fix. With these two patches (and the one I
sent the other day for add_missing_dev) I haven't hit any lockdep splats in 6
runs of xfstests on 3 different VMs in the last 12 hours. That means it should
take Dave at least 2 runs before he hits a new one. Thanks,
Josef Bacik (4):
btrfs: fix lockdep splat in add_missing_dev
btrfs: init sysfs for devices outside of the chunk_mutex
btrfs: kill the rcu protection for fs_info->space_info
btrfs: do not create raid sysfs entries under any locks
fs/btrfs/block-group.c | 47 ++++++++++++++++++++++++------------------
fs/btrfs/ioctl.c | 10 ++-------
fs/btrfs/space-info.c | 14 ++++---------
fs/btrfs/super.c | 5 +----
fs/btrfs/sysfs.c | 25 ++++++++++++++++++++--
fs/btrfs/volumes.c | 17 ++++++++++++---
6 files changed, 71 insertions(+), 47 deletions(-)
--
2.26.2
next reply other threads:[~2020-09-01 21:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:40 Josef Bacik [this message]
2020-09-01 21:40 ` [PATCH 1/4] btrfs: fix lockdep splat in add_missing_dev Josef Bacik
2020-09-02 6:23 ` Anand Jain
2020-09-03 11:17 ` David Sterba
2020-09-01 21:40 ` [PATCH 2/4] btrfs: init sysfs for devices outside of the chunk_mutex Josef Bacik
2020-09-02 6:21 ` Anand Jain
2020-09-02 17:45 ` David Sterba
2020-09-03 11:41 ` Anand Jain
2020-09-03 11:42 ` Anand Jain
2020-09-03 11:18 ` David Sterba
2020-09-01 21:40 ` [PATCH 3/4] btrfs: kill the rcu protection for fs_info->space_info Josef Bacik
2020-09-02 8:04 ` Nikolay Borisov
2020-09-02 10:32 ` David Sterba
2020-09-01 21:40 ` [PATCH 4/4] btrfs: do not create raid sysfs entries under any locks Josef Bacik
2020-09-08 12:40 ` David Sterba
2020-09-08 12:52 ` Josef Bacik
2020-09-04 14:20 ` [PATCH 0/4][v2] Lockdep fixes David Sterba
2020-09-07 13:05 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1598996236.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox