linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/3] Delayed inode error handling fixes
Date: Fri, 21 May 2021 16:44:06 -0400	[thread overview]
Message-ID: <cover.1621629737.git.josef@toxicpanda.com> (raw)

Hello,

Here are 3 straightforward fixes, but they rely on eachother so I'm sending them
as a series.  The first changes how we do cleanup so that it can do the right
thing in the case that we don't have an iref, this is to make the code cleaner
in the error case.  The second patch is to fix the error handling in
__btrfs_update_delayed_inode so it actually does the proper cleanup if there's
an error.  And finally the last patch add's the abort() we need in order to not
leave behind improper inode items that trip up fsck during error injection
testing.  Thanks,

Josef

Josef Bacik (3):
  btrfs: make btrfs_release_delayed_iref handle the !iref case
  btrfs: fix error handling in __btrfs_update_delayed_inode
  btrfs: abort transaction if we fail to update the delayed inode

 fs/btrfs/delayed-inode.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

-- 
2.26.3


             reply	other threads:[~2021-05-21 20:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 20:44 Josef Bacik [this message]
2021-05-21 20:44 ` [PATCH 1/3] btrfs: make btrfs_release_delayed_iref handle the !iref case Josef Bacik
2021-05-21 20:44 ` [PATCH 2/3] btrfs: fix error handling in __btrfs_update_delayed_inode Josef Bacik
2021-05-21 20:44 ` [PATCH 3/3] btrfs: abort transaction if we fail to update the delayed inode Josef Bacik
2021-05-24 19:44 ` [PATCH 0/3] Delayed inode error handling fixes David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1621629737.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).