From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs: fix mount/remount failure due to past device flush errors
Date: Tue, 7 Sep 2021 16:15:48 +0100 [thread overview]
Message-ID: <cover.1631026981.git.fdmanana@suse.com> (raw)
In-Reply-To: <f9dfa4183e5c84f71c3f50d504e3d6cdc43b0ae9.1630919202.git.fdmanana@suse.com>
From: Filipe Manana <fdmanana@suse.com>
We currently fail mounting and remounting a fs from RO to RW if we had a
device flush error from a past mount. This causes mount/remount when
such errors were transient and don't happen anymore. One example is during
tests that explicitly trigger IO failure, such as the new generic/648 or,
much less frequently, generic/019 and generic/475. The first patch has
more details in its changelog.
V2: Rework to use instead an additional argument to btrfs_check_rw_degradable()
and solve the same problem for remounts from RO to RW mode. Also added the
second patch.
Filipe Manana (2):
btrfs: fix mount failure due to past and transient device flush error
btrfs: remove the failing device argument from btrfs_check_rw_degradable()
fs/btrfs/disk-io.c | 4 ++--
fs/btrfs/super.c | 2 +-
fs/btrfs/volumes.c | 32 +++++++++++++++++++++-----------
fs/btrfs/volumes.h | 2 +-
4 files changed, 25 insertions(+), 15 deletions(-)
--
2.33.0
next prev parent reply other threads:[~2021-09-07 15:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 9:09 [PATCH] btrfs: fix mount failure due to past and transient device flush error fdmanana
2021-09-07 11:26 ` David Sterba
2021-09-07 15:15 ` Filipe Manana
2021-09-07 15:15 ` fdmanana [this message]
2021-09-07 15:15 ` [PATCH 1/2] " fdmanana
2021-09-08 14:19 ` Anand Jain
2021-09-08 14:26 ` Filipe Manana
2021-09-08 16:30 ` David Sterba
2021-09-08 17:32 ` Filipe Manana
2021-09-08 18:05 ` [PATCH v3] " fdmanana
2021-09-09 15:43 ` David Sterba
2021-09-07 15:15 ` [PATCH 2/2] btrfs: remove the failing device argument from btrfs_check_rw_degradable() fdmanana
2021-09-07 16:05 ` David Sterba
2021-09-08 14:25 ` Anand Jain
2021-09-09 14:19 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1631026981.git.fdmanana@suse.com \
--to=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox