From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 0/2] Free space tree space reservation fixes
Date: Thu, 2 Dec 2021 15:34:30 -0500 [thread overview]
Message-ID: <cover.1638477127.git.josef@toxicpanda.com> (raw)
v1->v2:
- Updated the changelog for "btrfs: reserve extra space for free space tree" to
make it clear why we're doubling the space reservation per Nikolay's request.
--- Original email ---
Hello,
Filipe reported a problem where he was getting an ENOSPC abort when running
delayed refs for generic/619. This is because of two reasons, first generic/619
creates a very small file system, and our global block rsv calculation doesn't
take into account the size of the free space tree. Thus we could get into a
situation where the global block rsv was not enough to handle the overflow.
The second is because we simply do not reserve space for the free space tree
modifications. Fix this by making sure any free space tree root has their block
rsv set to the delayed refs rsv, and then make sure if we have the free space
tree enabled we're reserving extra space for those operations.
With these patches the problem Filipe was hitting went away. Thanks,
Josef
Josef Bacik (2):
btrfs: include the free space tree in the global rsv minimum
calculation
btrfs: reserve extra space for the free space tree
fs/btrfs/block-rsv.c | 31 ++++++++++++++++++-------------
fs/btrfs/delayed-ref.c | 22 ++++++++++++++++++++++
2 files changed, 40 insertions(+), 13 deletions(-)
--
2.26.3
next reply other threads:[~2021-12-02 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 20:34 Josef Bacik [this message]
2021-12-02 20:34 ` [PATCH v2 1/2] btrfs: include the free space tree in the global rsv minimum calculation Josef Bacik
2021-12-02 20:34 ` [PATCH v2 2/2] btrfs: reserve extra space for the free space tree Josef Bacik
2021-12-06 10:44 ` Filipe Manana
2021-12-06 19:43 ` Josef Bacik
2021-12-03 13:09 ` [PATCH v2 0/2] Free space tree space reservation fixes Nikolay Borisov
2021-12-06 10:42 ` Filipe Manana
2021-12-06 19:54 ` Josef Bacik
2021-12-07 18:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1638477127.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox