From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs: defrag: don't defrag extents already at their max capacity, then remove an ambiguous check
Date: Thu, 27 Jan 2022 13:24:41 +0800 [thread overview]
Message-ID: <cover.1643260816.git.wqu@suse.com> (raw)
Thanks to the report from Filipe where he found a new bug in compressed
defrag, that we will try to defrag all compressed extents even it's
already at its max compacity.
This behavior is from the beginning of btrfs defrag.
The first patch is to fix the behavior, by just rejecting extents
which are already at their max capacity, nor allowing extents to be
merged with extents at their max capacity.
The second patch is to remove an ambiguous rejection condition.
The condition is believed to reject compressed extent, but it never
really works due to the check is > 128K, not >= 128K.
And the physically adajcent check may prevent users to reduce the number
of extents.
Qu Wenruo (2):
btrfs: defrag: don't defrag extents which is already at its max
capacity
btrfs: defrag: remove an ambiguous condition for rejection
fs/btrfs/ioctl.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
--
2.34.1
next reply other threads:[~2022-01-27 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 5:24 Qu Wenruo [this message]
2022-01-27 5:24 ` [PATCH 1/2] btrfs: defrag: don't defrag extents which is already at its max capacity Qu Wenruo
2022-01-27 10:48 ` Filipe Manana
2022-01-27 5:24 ` [PATCH 2/2] btrfs: defrag: remove an ambiguous condition for rejection Qu Wenruo
2022-01-27 10:49 ` Filipe Manana
2022-01-27 10:53 ` [PATCH 0/2] btrfs: defrag: don't defrag extents already at their max capacity, then remove an ambiguous check Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1643260816.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).