Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Naohiro Aota <naohiro.aota@wdc.com>
To: linux-btrfs@vger.kernel.org
Cc: Naohiro Aota <naohiro.aota@wdc.com>
Subject: [PATCH v2 0/5] btrfs: zoned: fixes for zone finishing
Date: Tue,  3 May 2022 17:48:49 -0700	[thread overview]
Message-ID: <cover.1651624820.git.naohiro.aota@wdc.com> (raw)

- Changes
 - v2
   - Rename some functions/variables.
   - Intoduce btrfs_zoned_bg_is_full() to check if a block group is fully
     allocated or not.
   - Add some more comments.

* Note: this series depends on "btrfs: zoned: fix zone activation logic"
  series (patch 1). I found the bug addressed in the series while I'm
  introducing the helper. 

Commit be1a1d7a5d24 ("btrfs: zoned: finish fully written block group")
introduced zone finishing a block group when the IO reaches at the end of
the block group. However, since the zone capacity may not aligned to 16KB
(node size), we can leave an un-allocatable space at the end of a block
group. Also, it turned out that metadata zone finishing never works
actually.

This series addresses these issues by rewriting metadata zone finishing
code to use a workqueue to process the finishing work.

Patch 1 introduces a helper to check if a block group is fully allocated.
The helper is used in patch 2.

Patch 2 is a clean-up patch to consolidate zone finishing function for
better maintainability.

Patch 3 changes the left region calculation so that it finishes a block
group when there is no more space left for allocation.

Patch 4 fixes metadata block group finishing which is not actually working.

Patch 5 implements zone finishing of an unused block group and fixes active
block group accounting. This patch is a bit unrelated to other ones. But,
the patch is tested with the previous patches applied, so let me go with
the same series.

Naohiro Aota (5):
  btrfs: zoned: introduce btrfs_zoned_bg_is_full
  btrfs: zoned: consolidate zone finish function
  btrfs: zoned: finish BG when there are no more allocatable bytes left
  btrfs: zoned: properly finish block group on metadata write
  btrfs: zoned: zone finish unused block group

 fs/btrfs/block-group.c |   8 ++
 fs/btrfs/block-group.h |   2 +
 fs/btrfs/extent-tree.c |   3 +-
 fs/btrfs/extent_io.c   |   6 +-
 fs/btrfs/extent_io.h   |   1 -
 fs/btrfs/zoned.c       | 176 ++++++++++++++++++++++++-----------------
 fs/btrfs/zoned.h       |  11 +++
 7 files changed, 128 insertions(+), 79 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-05-04  0:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  0:48 Naohiro Aota [this message]
2022-05-04  0:48 ` [PATCH v2 1/5] btrfs: zoned: introduce btrfs_zoned_bg_is_full Naohiro Aota
2022-05-04  0:48 ` [PATCH v2 2/5] btrfs: zoned: consolidate zone finish function Naohiro Aota
2022-05-04 16:00   ` Johannes Thumshirn
2022-05-04  0:48 ` [PATCH v2 3/5] btrfs: zoned: finish BG when there are no more allocatable bytes left Naohiro Aota
2022-05-04  0:48 ` [PATCH v2 4/5] btrfs: zoned: properly finish block group on metadata write Naohiro Aota
2022-05-04  0:48 ` [PATCH v2 5/5] btrfs: zoned: zone finish unused block group Naohiro Aota
2022-05-04 15:20 ` [PATCH v2 0/5] btrfs: zoned: fixes for zone finishing David Sterba
2022-05-04 16:02 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1651624820.git.naohiro.aota@wdc.com \
    --to=naohiro.aota@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox