From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 0/9] btrfs: block group cleanups
Date: Fri, 15 Jul 2022 15:45:20 -0400 [thread overview]
Message-ID: <cover.1657914198.git.josef@toxicpanda.com> (raw)
v1->v2:
- I'm an idiot and didn't rebase properly, so adding the two other cleanups I
had that I didn't send.
- Rebased onto a recent misc-next and fixed the compile errors.
- Realized that with the new zoned patches that caused the compile error that
btrfs_update_space_info needed to be cleaned up, so added patches for that.
--- Original email ---
I'm reworking our relocation and delete unused block group workqueues which
require some cleanups of how we deal with flags on the block group. We've had a
bit field for various flags on the block group for a while, but there's a subtle
gotcha with this bitfield in that you have to protect every modification with
bg->lock in order to not mess with the values, and there were a few places that
we weren't holding the lock.
Rework these to be normal flags, and then go behind this conversion and cleanup
some of the usage of the different flags. Additionally there's a cleanup around
when to break out of the background workers. Thanks,
Josef
Josef Bacik (9):
btrfs: use btrfs_fs_closing for background bg work
btrfs: simplify btrfs_update_space_info
btrfs: handle space_info setting of bg in btrfs_add_bg_to_space_info
btrfs: convert block group bit field to use bit helpers
btrfs: remove block_group->lock protection for TO_COPY
btrfs: simplify btrfs_put_block_group_cache
btrfs: remove BLOCK_GROUP_FLAG_HAS_CACHING_CTL
btrfs: remove bg->lock protection for relocation repair flag
btrfs: delete btrfs_wait_space_cache_v1_finished
fs/btrfs/block-group.c | 142 +++++++++++++-----------------------
fs/btrfs/block-group.h | 21 +++---
fs/btrfs/dev-replace.c | 11 +--
fs/btrfs/extent-tree.c | 7 +-
fs/btrfs/free-space-cache.c | 18 ++---
fs/btrfs/scrub.c | 16 ++--
fs/btrfs/space-info.c | 38 +++++-----
fs/btrfs/space-info.h | 6 +-
fs/btrfs/volumes.c | 16 ++--
fs/btrfs/zoned.c | 34 ++++++---
10 files changed, 137 insertions(+), 172 deletions(-)
--
2.26.3
next reply other threads:[~2022-07-15 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 19:45 Josef Bacik [this message]
2022-07-15 19:45 ` [PATCH v2 1/9] btrfs: use btrfs_fs_closing for background bg work Josef Bacik
2022-07-15 19:45 ` [PATCH v2 2/9] btrfs: simplify btrfs_update_space_info Josef Bacik
2022-07-15 19:45 ` [PATCH v2 3/9] btrfs: handle space_info setting of bg in btrfs_add_bg_to_space_info Josef Bacik
2022-07-15 19:45 ` [PATCH v2 4/9] btrfs: convert block group bit field to use bit helpers Josef Bacik
2022-07-15 19:45 ` [PATCH v2 5/9] btrfs: remove block_group->lock protection for TO_COPY Josef Bacik
2022-07-15 19:45 ` [PATCH v2 6/9] btrfs: simplify btrfs_put_block_group_cache Josef Bacik
2022-07-15 19:45 ` [PATCH v2 7/9] btrfs: remove BLOCK_GROUP_FLAG_HAS_CACHING_CTL Josef Bacik
2022-07-15 19:45 ` [PATCH v2 8/9] btrfs: remove bg->lock protection for relocation repair flag Josef Bacik
2022-07-15 19:45 ` [PATCH v2 9/9] btrfs: delete btrfs_wait_space_cache_v1_finished Josef Bacik
2022-08-04 17:25 ` [PATCH v2 0/9] btrfs: block group cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1657914198.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox