Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/3] btrfs-progs: avoid repeated data write for metadata and a small cleanup
Date: Tue,  2 Aug 2022 15:52:40 +0800	[thread overview]
Message-ID: <cover.1659426744.git.wqu@suse.com> (raw)

[CHANGELOG]
v2:
- Separate the fixes from the initial patch
- Fix a bug in BUG_ON() condition which causes mkfs test failure

There is a bug report from Shinichiro that for zoned device mkfs -m DUP
(using RST) doesn't work.

It turns out to be a bug in commit 2a93728391a1 ("btrfs-progs: use
write_data_to_disk() to replace write_extent_to_disk()"), which I
wrongly assumed that write_data_to_disk() will only write the data to
one mirror.

In fact, write_data_to_disk() writes data to all mirrors, thus the
@mirror argument is completely unnecessary.

The first patch will fix the problem and cleanup the unnecessary
argument to avoid confusion.

Then the 2nd patch will fix a BUG_ON() condition.

Finally the last patch will cleanup write_and_map_eb() to completely
rely on write_data_to_disk(), without manually handling RAID56. 


Qu Wenruo (3):
  btrfs-progs: avoid repeated data write for metadata
  btrfs-progs: fix a BUG_ON() condition for write_data_to_disk()
  btrfs-progs: use write_data_to_disk() to handle RAID56 in
    write_and_map_eb()

 image/main.c              |  2 +-
 kernel-shared/disk-io.c   | 39 +++------------------------------------
 kernel-shared/extent_io.c | 12 +++++++++---
 kernel-shared/extent_io.h |  2 +-
 4 files changed, 14 insertions(+), 41 deletions(-)

-- 
2.37.0


             reply	other threads:[~2022-08-02  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  7:52 Qu Wenruo [this message]
2022-08-02  7:52 ` [PATCH v2 1/3] btrfs-progs: avoid repeated data write for metadata Qu Wenruo
2022-08-02  7:52 ` [PATCH v2 2/3] btrfs-progs: fix a BUG_ON() condition for write_data_to_disk() Qu Wenruo
2022-08-02  7:52 ` [PATCH v2 3/3] btrfs-progs: use write_data_to_disk() to handle RAID56 in write_and_map_eb() Qu Wenruo
2022-08-02  8:04 ` [PATCH v2 0/3] btrfs-progs: avoid repeated data write for metadata and a small cleanup Johannes Thumshirn
2022-08-02  8:06   ` Qu Wenruo
2022-08-02  8:34 ` Shinichiro Kawasaki
2022-08-03 19:25 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1659426744.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox