linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Burkov <boris@bur.io>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
	'Filipe Manana ' <fdmanana@kernel.org>
Subject: [PATCH v2 0/2] btrfs: minor reclaim tuning
Date: Thu, 13 Oct 2022 15:52:08 -0700	[thread overview]
Message-ID: <cover.1665701210.git.boris@bur.io> (raw)

Two minor reclaim fixes that reduce relocations when they aren't quite
necessary. These are a basic first step in a broader effort to reduce
the alarmingly high rate of relocation we have observed in production
at Meta.

The first patch skips empty relocation.

The second patch skips relocation that no longer passes the reclaim
threshold check at reclaim time.

Changes in v2:
- added the re-check patch
- improved commit message and comment in the skip-empty patch.

Boris Burkov (2):
  btrfs: skip reclaim if block_group is empty
  btrfs: re-check reclaim condition in reclaim worker

 fs/btrfs/block-group.c | 83 +++++++++++++++++++++++++++++-------------
 1 file changed, 58 insertions(+), 25 deletions(-)

-- 
2.38.0


             reply	other threads:[~2022-10-13 22:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13 22:52 Boris Burkov [this message]
2022-10-13 22:52 ` [PATCH v2 1/2] btrfs: skip reclaim if block_group is empty Boris Burkov
2022-10-13 22:52 ` [PATCH v2 2/2] btrfs: re-check reclaim condition in reclaim worker Boris Burkov
2022-10-14  8:43   ` David Sterba
2022-10-14 10:24 ` [PATCH v2 0/2] btrfs: minor reclaim tuning Filipe Manana
2022-10-14 14:09 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1665701210.git.boris@bur.io \
    --to=boris@bur.io \
    --cc=fdmanana@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).