public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Burkov <boris@bur.io>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v3 0/2] btrfs: fix size class loading logic
Date: Wed, 15 Feb 2023 12:59:48 -0800	[thread overview]
Message-ID: <cover.1676494550.git.boris@bur.io> (raw)

Unfortunately, this code needs another fixup, as Filipe discovered that
the fixup's use of search_forward caused a deadlock with a thread
holding the tree root lock and blocked on caching.

---
Changelog:
V3: move to btrfs_for_each_slot, drop contention checking logic. Sysfs
patch holds groups sem, but releases it between raid loops if it is
contended, matching the behavior of the raid_bytes file.
V2: just organizational changes to how the original fixup was sent

Boris Burkov (2):
  btrfs: add size class stats to sysfs
  btrfs: fix size class loading logic

 fs/btrfs/block-group.c | 42 +++++++++++++++-------------------------
 fs/btrfs/sysfs.c       | 44 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+), 26 deletions(-)

-- 
2.38.1


             reply	other threads:[~2023-02-15 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 20:59 Boris Burkov [this message]
2023-02-15 20:59 ` [PATCH v3 1/2] btrfs: add size class stats to sysfs Boris Burkov
2023-02-20 19:40   ` David Sterba
2023-02-15 20:59 ` [PATCH v3 2/2] btrfs: fix size class loading logic Boris Burkov
2023-02-20 19:42   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1676494550.git.boris@bur.io \
    --to=boris@bur.io \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox