public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs-progs: convert: fix csum generation for migrated ranges
Date: Tue,  9 May 2023 08:43:13 +0800	[thread overview]
Message-ID: <cover.1683592875.git.wqu@suse.com> (raw)

There is an internal report that btrfs/012 failed on 64K page size
systems.

It turns out that with 64K block size for ext4, even an empty ext4 can
lead to csum errors for the image file.

The root cause is the bad csum generation, which read incorrect data
from the disk, and leads to bad csum generated. (while the on-disk data
is still correct).

This patchset would fix the bug and add a test case for it.

Qu Wenruo (2):
  btrfs-progs: convert: fix bad csum for migrated range.
  btrfs-progs: tests/convert: add a test case to check the csum for the
    image file

 convert/main.c                                   | 12 ++++++++++--
 .../023-64k-blocksize-migrated/test.sh           | 16 ++++++++++++++++
 2 files changed, 26 insertions(+), 2 deletions(-)
 create mode 100755 tests/convert-tests/023-64k-blocksize-migrated/test.sh

-- 
2.40.1


             reply	other threads:[~2023-05-09  0:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  0:43 Qu Wenruo [this message]
2023-05-09  0:43 ` [PATCH 1/2] btrfs-progs: convert: fix bad csum for migrated range Qu Wenruo
2023-05-09  0:43 ` [PATCH 2/2] btrfs-progs: tests/convert: add a test case to check the csum for the image file Qu Wenruo
2023-05-09  1:48   ` Anand Jain
2023-05-10 16:42 ` [PATCH 0/2] btrfs-progs: convert: fix csum generation for migrated ranges David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1683592875.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox