From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs-progs: parser related cleanups
Date: Wed, 17 Jan 2024 14:40:38 +1030 [thread overview]
Message-ID: <cover.1705464240.git.wqu@suse.com> (raw)
Btrfs-progs has two types of parsers:
- parse_*()
Those would return 0 for a good parse, and save the value into a
pointer.
Callers are responsible to handle the error.
- arg_strto*()
Those would directly return the parsed value, and call exit(1)
directly for errors.
However this split is not perfect:
- A lot of code can be shared between them
In fact, mostly arg_strto*() can be implement using parse_*().
The only difference is in how detailed the error string would be.
- parse_size_from_string() doesn't follow the scheme
It follows arg_strto*() behavior but has the parse_*() name.
This patch would:
- Use parse_u64() to implement arg_strtou64()
The first patch.
- Use parse_u64_with_suffix() to implement arg_strtou64_with_suffix()
The new helper parse_u64_with_suffix() would replace the old
parse_size_from_string() and do the proper error handling.
Qu Wenruo (2):
btrfs-progs: use parse_u64() to implement arg_strtou64()
btrfs-progs: implement arg_strtou64_with_suffix() with a new helper
cmds/filesystem.c | 15 ++++----
cmds/qgroup.c | 3 +-
cmds/reflink.c | 7 ++--
cmds/scrub.c | 2 +-
common/parse-utils.c | 85 ++++++++++++++++++++++++++++---------------
common/parse-utils.h | 2 +-
common/string-utils.c | 45 +++++++++++++++--------
common/string-utils.h | 3 ++
convert/main.c | 3 +-
kernel-shared/zoned.c | 4 +-
mkfs/main.c | 6 +--
11 files changed, 110 insertions(+), 65 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-17 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 4:10 Qu Wenruo [this message]
2024-01-17 4:10 ` [PATCH 1/2] btrfs-progs: use parse_u64() to implement arg_strtou64() Qu Wenruo
2024-01-17 4:10 ` [PATCH 2/2] btrfs-progs: implement arg_strtou64_with_suffix() with a new helper Qu Wenruo
2024-01-17 19:34 ` [PATCH 0/2] btrfs-progs: parser related cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1705464240.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox