public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Burkov <boris@bur.io>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/2] btrfs: subvol qgroup lifetime invariants
Date: Fri, 19 Jan 2024 16:55:57 -0800	[thread overview]
Message-ID: <cover.1705711967.git.boris@bur.io> (raw)

Subvol qgroups (id 0/SUBVOLID) are special. They get created
and reaped automatically for subvols, and can never have any children by
virtue of being at level 0.

Manually managing them doesn't provide much value but does create the
possibility for weird states and races. To that end, ban deleting subvol
qgroups that still have usage and creating subvol qgroups at all.

Testing Note: this patch series breaks btrfs/303 as that test is hunting
a race to do with creating a subvol qgroup which now explicitly fails.

Boris Burkov (2):
  btrfs: forbid creating subvol qgroups
  btrfs: forbid deleting live subvol qgroup

 fs/btrfs/ioctl.c  |  5 +++++
 fs/btrfs/qgroup.c | 15 +++++++++++++++
 2 files changed, 20 insertions(+)

-- 
2.43.0


             reply	other threads:[~2024-01-20  0:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20  0:55 Boris Burkov [this message]
2024-01-20  0:55 ` [PATCH 1/2] btrfs: forbid creating subvol qgroups Boris Burkov
2024-01-20  2:57   ` Qu Wenruo
2024-01-22 20:43   ` David Sterba
2024-01-24 12:52   ` Neal Gompa
2024-01-24 16:36     ` David Sterba
2024-01-25  3:32       ` Neal Gompa
2024-01-25 23:12         ` Boris Burkov
2024-01-26 15:50           ` Neal Gompa
2024-01-20  0:55 ` [PATCH 2/2] btrfs: forbid deleting live subvol qgroup Boris Burkov
2024-01-20  2:58   ` Qu Wenruo
2024-01-22 20:43   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1705711967.git.boris@bur.io \
    --to=boris@bur.io \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox