public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/2] btrfs: some fiemap fixes
Date: Fri, 23 Feb 2024 23:47:24 +0000	[thread overview]
Message-ID: <cover.1708730657.git.fdmanana@suse.com> (raw)
In-Reply-To: <cover.1708635463.git.fdmanana@suse.com>

From: Filipe Manana <fdmanana@suse.com>

There's a recent regression with fiemap due to a fix for a deadlock between
fiemap and memory mapped writes when the fiemap buffer is memory mapped to
the same file range, which leads to a race triggering a warning and making
fiemap fail. Plus one more long standing race when using FIEMAP_FLAG_SYNC.
Details in the change logs.

V3: Deal with the case where offset == cache->offset which is also
    possible if we had delalloc in the range of a hole or prealloc extent.

V2: Updated patch 1/2 to deal with the case of a hole/prealloc extent
    with multiple delalloc ranges inside it.

Filipe Manana (2):
  btrfs: fix race between ordered extent completion and fiemap
  btrfs: ensure fiemap doesn't race with writes when FIEMAP_FLAG_SYNC is given

 fs/btrfs/extent_io.c | 59 ++++++++++++++++++++++++++++++--------------
 fs/btrfs/inode.c     | 22 ++++++++++++++++-
 2 files changed, 61 insertions(+), 20 deletions(-)

-- 
2.40.1


  parent reply	other threads:[~2024-02-23 23:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  8:08 [PATCH 0/2] btrfs: some fiemap fixes fdmanana
2024-02-23  8:08 ` [PATCH 1/2] btrfs: fix race between ordered extent completion and fiemap fdmanana
2024-02-23  8:08 ` [PATCH 2/2] btrfs: ensure fiemap doesn't race with writes when FIEMAP_FLAG_SYNC is given fdmanana
2024-02-23 15:19 ` [PATCH v2 0/2] btrfs: some fiemap fixes fdmanana
2024-02-23 15:19   ` [PATCH v2 1/2] btrfs: fix race between ordered extent completion and fiemap fdmanana
2024-02-23 15:19   ` [PATCH v2 2/2] btrfs: ensure fiemap doesn't race with writes when FIEMAP_FLAG_SYNC is given fdmanana
2024-02-23 23:47 ` fdmanana [this message]
2024-02-23 23:47   ` [PATCH v3 1/2] btrfs: fix race between ordered extent completion and fiemap fdmanana
2024-02-23 23:47   ` [PATCH v3 2/2] btrfs: ensure fiemap doesn't race with writes when FIEMAP_FLAG_SYNC is given fdmanana
2024-02-25 19:51 ` [PATCH v4 0/2] btrfs: some fiemap fixes fdmanana
2024-02-25 19:51   ` [PATCH v4 1/2] btrfs: fix race between ordered extent completion and fiemap fdmanana
2024-02-25 19:51   ` [PATCH v4 2/2] btrfs: ensure fiemap doesn't race with writes when FIEMAP_FLAG_SYNC is given fdmanana
2024-02-26 16:58   ` [PATCH v4 0/2] btrfs: some fiemap fixes Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1708730657.git.fdmanana@suse.com \
    --to=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox