Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/2] btrfs: enhance function extent_range_clear_dirty_for_io()
Date: Thu, 23 May 2024 10:49:36 +0930	[thread overview]
Message-ID: <cover.1716427131.git.wqu@suse.com> (raw)

[Changelog]
v3:
- Drop the patch to use subpage helper
  For subpage cases, fsstress with compression can lead to hang where
  OE seems hanging and never to be finished.
  So far it looks like some race with i_size change but still not sure
  why the code change is involved.
  Drop the subpage helper change for now.

v2:
- Split the original patch into 3

- Return the error from filemap_get_folio() to be future-proof

- Enhance the comments for the new ASSERT() on
  extent_range_clear_dirty_for_io() error
  In fact, even if some pages are missing, we do not need to handle the
  error at compress_file_range(), as btrfs_compress_folios() and each
  compression routine would handle the missing folio correctly.

  Thus the new ASSERT() is only an early warning for developers.

Qu Wenruo (2):
  btrfs: move extent_range_clear_dirty_for_io() into inode.c
  btrfs: remove the BUG_ON() inside extent_range_clear_dirty_for_io()

 fs/btrfs/extent_io.c | 15 ---------------
 fs/btrfs/extent_io.h |  1 -
 fs/btrfs/inode.c     | 31 ++++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 17 deletions(-)

-- 
2.45.1


             reply	other threads:[~2024-05-23  1:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23  1:19 Qu Wenruo [this message]
2024-05-23  1:19 ` [PATCH v3 1/2] btrfs: move extent_range_clear_dirty_for_io() into inode.c Qu Wenruo
2024-05-23  1:19 ` [PATCH v3 2/2] btrfs: remove the BUG_ON() inside extent_range_clear_dirty_for_io() Qu Wenruo
2024-07-02 16:43 ` [PATCH v3 0/2] btrfs: enhance function extent_range_clear_dirty_for_io() David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1716427131.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox