public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/2] btrfs: add a delayed ref self test
Date: Thu, 14 Nov 2024 14:57:47 -0500	[thread overview]
Message-ID: <cover.1731614132.git.josef@toxicpanda.com> (raw)

Hello,

I made a silly mistake when refactoring the delayed ref code to make it easier
to understand, and that resulted in a whole lot of not fun trying to find what
went wrong with boxes started falling over when we were deploying 6.11.  This
style of bug is easy to catch with basic unit testing, so add a variety of unit
tests for delayed refs to make sure I don't break things again.  One patch moves
an important helper and exports it so that we can do the testing, the other
patch is a giant patch of all the tests with a few changes that are necessary to
make everything work.  I validated these work properly and catch a variety of
bugs that I hand introduced to the delayed ref code.  Thanks,

Josef Bacik (2):
  btrfs: move select_delayed_ref and export it
  btrfs: add delayed ref self tests

 fs/btrfs/Makefile                   |    2 +-
 fs/btrfs/delayed-ref.c              |   41 +-
 fs/btrfs/delayed-ref.h              |    2 +
 fs/btrfs/extent-tree.c              |   26 +-
 fs/btrfs/tests/btrfs-tests.c        |   18 +
 fs/btrfs/tests/btrfs-tests.h        |    6 +
 fs/btrfs/tests/delayed-refs-tests.c | 1012 +++++++++++++++++++++++++++
 7 files changed, 1078 insertions(+), 29 deletions(-)
 create mode 100644 fs/btrfs/tests/delayed-refs-tests.c

-- 
2.43.0


             reply	other threads:[~2024-11-14 19:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 19:57 Josef Bacik [this message]
2024-11-14 19:57 ` [PATCH 1/2] btrfs: move select_delayed_ref and export it Josef Bacik
2024-11-14 19:57 ` [PATCH 2/2] btrfs: add delayed ref self tests Josef Bacik
2024-11-14 22:23   ` Boris Burkov
2024-11-15 14:42     ` Josef Bacik
2024-11-15 18:33   ` David Sterba
2024-12-06 19:51     ` David Sterba
2024-12-09 14:01       ` Josef Bacik
2024-11-26 15:34   ` David Sterba
2024-11-14 22:24 ` [PATCH 0/2] btrfs: add a delayed ref self test Boris Burkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1731614132.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox